Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.4
Choose a base ref
...
head repository: krciga22/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: issue-51564
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 11, 2023

  1. Issue 51564 - cloned TraceableStack operates differently than StackMi… 

    …ddleware

Tested fixing the issue by implementing __clone() for TraceableStack.
    @krciga22
    krciga22 committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9c71a0e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Don't clone stopwatch since the clone will not be utilized by the pro… 

    …filer or anything else
    @krciga22
    krciga22 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1e44f0b View commit details
    Browse the repository at this point in the history

  2. Refactor and cleanup

    @krciga22
    krciga22 committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e46dba8 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Test stopwatch start and stop when there's a cloned TraceableStack

    @krciga22
    krciga22 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    36dc8dc View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Move class_exists() inside of the test as it is irrelevant outside

    @krciga22
    krciga22 committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    dd8a3b3 View commit details
    Browse the repository at this point in the history

  2. Rename and refactor test to focus on unstacking the clone of Traceabl… 

    …eStack independently

Notes:
- This test manually unstacks TraceableStack and it's clone instead of using a MessageBus, which is what StackMiddlewareTest::testClone() uses. I did this because MessageBus always dispatches with a new StackMiddleware(). I thought about using a custom MessageBus mock, however, I'm not sure if it's needed to test unstacking.
- Removed stopwatch expects() as the stopwatch is not currently under test
    @krciga22
    krciga22 committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    7ae895f View commit details
    Browse the repository at this point in the history

  3. Test a cloned TraceableStack uses the same stopwatch as the original

    @krciga22
    krciga22 committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    859db92 View commit details
    Browse the repository at this point in the history
Loading