Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.3.1
Choose a base ref
...
head repository: symfony/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.3.2
Choose a head ref
  • 15 commits
  • 9 files changed
  • 7 contributors

Commits on May 29, 2017

  1. Configuration menu
    Copy the full SHA
    84f5de9 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2017

  1. [DependencyInjection] Use more clear message when unused environment …

    …variables detected
    voronkovich authored and fabpot committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    6dbdb1b View commit details
    Browse the repository at this point in the history
  2. bug #22976 [DependencyInjection] Use more clear message when unused e…

    …nvironment variables detected (voronkovich)
    
    This PR was squashed before being merged into the 3.2 branch (closes #22976).
    
    Discussion
    ----------
    
    [DependencyInjection] Use more clear message when unused environment variables detected
    
    | Q             | A
    | ------------- | ---
    | Branch?       |3.2
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #22955
    | License       | MIT
    
    Old error message:
    ```
    Incompatible use of dynamic environment variables "DATABASE_URL", "MAILER_URL" found in parameters.
    ```
    
    New error message:
    ```
    Environment variables "DATABASE_URL", "MAILER_URL" are never used. Please, check your container's configuration.
    ```
    
    Commits
    -------
    
    6dbdb1b [DependencyInjection] Use more clear message when unused environment variables detected
    fabpot committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    12f5636 View commit details
    Browse the repository at this point in the history
  3. bug #22936 [Form] Mix attr option between guessed options and user op…

    …tions (yceruto)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Form] Mix attr option between guessed options and user options
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19871
    | License       | MIT
    
    Commits
    -------
    
    84f5de9 mix attr options between type-guess options and user options
    fabpot committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    621b769 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2017

  1. [Cache] MemcachedAdapter not working with TagAwareAdapter

    It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace.
    
    Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to '__tags__' in my project did the trick and I've been using it for a couple of days now and it seems fine.
    
    The reason I had to completely copy/paste this file in my local project is self:: instead of static:: usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags.
    wucdbm authored and nicolas-grekas committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    405f64b View commit details
    Browse the repository at this point in the history
  2. bug #23063 [Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX …

    …(wucdbm)
    
    This PR was submitted for the 3.3 branch but it was merged into the 3.2 branch instead (closes #23063).
    
    Discussion
    ----------
    
    [Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace.
    
    Edit: Just to clarify, `CacheItem::isHit()` always returned `false`. This is what I meant with the above.
    
    Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to `'__tags__'` in my project did the trick and I've been using it for a couple of days now and it seems fine.
    
    The reason I had to completely copy/paste this file in my local project is `self::` instead of `static::` usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags.
    
    PS: Not exactly sure what to do with tests. Any help would be appreciated.
    
    Commits
    -------
    
    405f64b [Cache] MemcachedAdapter not working with TagAwareAdapter
    nicolas-grekas committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    81a5057 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25df7a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2017

  1. [TwigBridge] Fix namespaced classes

    ogizanagi authored and fabpot committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    a1cdc2d View commit details
    Browse the repository at this point in the history
  2. bug #23073 [TwigBridge] Fix namespaced classes (ogizanagi)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [TwigBridge] Fix namespaced classes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7 <!-- see comment below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
    | BC breaks?    | no
    | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
    | Tests pass?   | yes
    | Fixed tickets | #23072 <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A
    
    Commits
    -------
    
    a1cdc2d [TwigBridge] Fix namespaced classes
    fabpot committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    658236b View commit details
    Browse the repository at this point in the history
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [TwigBridge] Fix namespaced classes
      mix attr options between type-guess options and user options
    fabpot committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    419556f View commit details
    Browse the repository at this point in the history
  4. Merge branch '2.8' into 3.2

    * 2.8:
      [TwigBridge] Fix namespaced classes
      mix attr options between type-guess options and user options
    fabpot committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    c297144 View commit details
    Browse the repository at this point in the history
  5. Merge branch '3.2' into 3.3

    * 3.2:
      [TwigBridge] Fix namespaced classes
      [Cache] MemcachedAdapter not working with TagAwareAdapter
      [DependencyInjection] Use more clear message when unused environment variables detected
      mix attr options between type-guess options and user options
    nicolas-grekas committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    7769179 View commit details
    Browse the repository at this point in the history
  6. updated CHANGELOG for 3.3.2

    fabpot committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    c1a6455 View commit details
    Browse the repository at this point in the history
  7. updated VERSION for 3.3.2

    fabpot committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    adf3a02 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #23078 from fabpot/release-3.3.2

    released v3.3.2
    fabpot authored Jun 6, 2017
    Configuration menu
    Copy the full SHA
    82bd7c0 View commit details
    Browse the repository at this point in the history
Loading