-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Comparing changes
Open a pull request
base repository: symfony/symfony
base: v3.3.1
head repository: symfony/symfony
compare: v3.3.2
- 15 commits
- 9 files changed
- 7 contributors
Commits on May 29, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 84f5de9 - Browse repository at this point
Copy the full SHA 84f5de9View commit details
Commits on Jun 3, 2017
-
[DependencyInjection] Use more clear message when unused environment …
…variables detected
Configuration menu - View commit details
-
Copy full SHA for 6dbdb1b - Browse repository at this point
Copy the full SHA 6dbdb1bView commit details -
bug #22976 [DependencyInjection] Use more clear message when unused e…
…nvironment variables detected (voronkovich) This PR was squashed before being merged into the 3.2 branch (closes #22976). Discussion ---------- [DependencyInjection] Use more clear message when unused environment variables detected | Q | A | ------------- | --- | Branch? |3.2 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22955 | License | MIT Old error message: ``` Incompatible use of dynamic environment variables "DATABASE_URL", "MAILER_URL" found in parameters. ``` New error message: ``` Environment variables "DATABASE_URL", "MAILER_URL" are never used. Please, check your container's configuration. ``` Commits ------- 6dbdb1b [DependencyInjection] Use more clear message when unused environment variables detected
Configuration menu - View commit details
-
Copy full SHA for 12f5636 - Browse repository at this point
Copy the full SHA 12f5636View commit details -
bug #22936 [Form] Mix attr option between guessed options and user op…
…tions (yceruto) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Mix attr option between guessed options and user options | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19871 | License | MIT Commits ------- 84f5de9 mix attr options between type-guess options and user options
Configuration menu - View commit details
-
Copy full SHA for 621b769 - Browse repository at this point
Copy the full SHA 621b769View commit details
Commits on Jun 5, 2017
-
[Cache] MemcachedAdapter not working with TagAwareAdapter
It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace. Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to '__tags__' in my project did the trick and I've been using it for a couple of days now and it seems fine. The reason I had to completely copy/paste this file in my local project is self:: instead of static:: usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags.
Configuration menu - View commit details
-
Copy full SHA for 405f64b - Browse repository at this point
Copy the full SHA 405f64bView commit details -
bug #23063 [Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX …
…(wucdbm) This PR was submitted for the 3.3 branch but it was merged into the 3.2 branch instead (closes #23063). Discussion ---------- [Cache] Fix extensibility of TagAwareAdapter::TAGS_PREFIX | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | It seems that when MemcachedAdapter is used with TagAwareAdapter, it fails to fetch items, even though I thoroughly tested fetching items with the exact same keys under the same namespace. Edit: Just to clarify, `CacheItem::isHit()` always returned `false`. This is what I meant with the above. Turns out the issue lies in `const TAGS_PREFIX = "\0tags\0";` for unknown to me reasons. Hardcoding that to `'__tags__'` in my project did the trick and I've been using it for a couple of days now and it seems fine. The reason I had to completely copy/paste this file in my local project is `self::` instead of `static::` usage. I am not sure whether that is a mistake or is done on purpose, but in order to have this work for me I need to be able to override that constant. Going with static:: seems like a good solution to me, then I can set whatever prefix I need for the tags. PS: Not exactly sure what to do with tests. Any help would be appreciated. Commits ------- 405f64b [Cache] MemcachedAdapter not working with TagAwareAdapter
Configuration menu - View commit details
-
Copy full SHA for 81a5057 - Browse repository at this point
Copy the full SHA 81a5057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25df7a1 - Browse repository at this point
Copy the full SHA 25df7a1View commit details
Commits on Jun 6, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a1cdc2d - Browse repository at this point
Copy the full SHA a1cdc2dView commit details -
bug #23073 [TwigBridge] Fix namespaced classes (ogizanagi)
This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] Fix namespaced classes | Q | A | ------------- | --- | Branch? | 2.7 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23072 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- a1cdc2d [TwigBridge] Fix namespaced classes
Configuration menu - View commit details
-
Copy full SHA for 658236b - Browse repository at this point
Copy the full SHA 658236bView commit details -
* 2.7: [TwigBridge] Fix namespaced classes mix attr options between type-guess options and user options
Configuration menu - View commit details
-
Copy full SHA for 419556f - Browse repository at this point
Copy the full SHA 419556fView commit details -
* 2.8: [TwigBridge] Fix namespaced classes mix attr options between type-guess options and user options
Configuration menu - View commit details
-
Copy full SHA for c297144 - Browse repository at this point
Copy the full SHA c297144View commit details -
* 3.2: [TwigBridge] Fix namespaced classes [Cache] MemcachedAdapter not working with TagAwareAdapter [DependencyInjection] Use more clear message when unused environment variables detected mix attr options between type-guess options and user options
Configuration menu - View commit details
-
Copy full SHA for 7769179 - Browse repository at this point
Copy the full SHA 7769179View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1a6455 - Browse repository at this point
Copy the full SHA c1a6455View commit details -
Configuration menu - View commit details
-
Copy full SHA for adf3a02 - Browse repository at this point
Copy the full SHA adf3a02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82bd7c0 - Browse repository at this point
Copy the full SHA 82bd7c0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.3.1...v3.3.2