[2.7] Expanded Entity Form Element with negative id values #15273

Waigie · 2015-07-14T14:55:22Z

Since 2.7 using expanded Entity Form Elements, which allow multiple selections (checkboxes) with data having negativ IDs is not possible anymore, because the new naming conventions prohibit names starting with a '-'

Example

Database Table

ID	Name
-1	Foo
1	Bar
2	Baz

Code

class ExampleForm extends Form
{
    public function buildForm(FormBuilderInterface $builder, array $options) {
        $builder->add(
            'element',
            'entity',
            array(
                'class' => 'AppBundle:ExampleEntity',
                'label' => 'Expanded Entity',
                'expanded' => true,
                'multiple' => true,
            )
        );
    }
}

Creating this form with the Symfony Form Builder will generate the following Error:

The name "-1" contains illegal characters. Names should start with a letter, digit or underscore and only contain letters, digits, numbers, underscores ("_"), hyphens ("-") and colons (":").

Prior to Symfony 2.7.0 everything works fine, including 2.6.10.

jakzal · 2015-07-14T17:42:01Z

Reproduced here.

jakzal · 2015-07-14T17:48:23Z

re #14050

@Waigie until this is fixed, you can implement a workaround and define a choice_name callback:

        $builder->add(
            'element',
            'entity',
            [
                'class' => ExampleEntity::class,
                'label' => 'Expanded Entity',
                'expanded' => true,
                'multiple' => true,
                'choice_name' => function ($choice) {
                    return str_replace('-', '_', $choice);
                }
            ]
        );

@webmozart

This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fix a BC break in the entity | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15273 | License | MIT | Doc PR | - @webmozart this brings back the old behaviour. Attached test case passes on 2.3 with no code modifications. Code [here](https://github.com/symfony/symfony/blob/73bbaa6cc7d706b0e945107657fbd240efec0c97/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L199-L206) promises any integer number can be handled with `createChoiceName()`: ```php // If the object has a single-column, numeric ID, use that ID as // field name. We can only use numeric IDs as names, as we cannot // guarantee that a non-numeric ID contains a valid form name if ($idReader->isIntId()) { return array(__CLASS__, 'createChoiceName'); } // Otherwise, an incrementing integer is used as name automatically ``` While `createChoiceName()` can only handle natural numbers. Commits ------- 03642b8 [Form] Fix a BC break in the entity

jakzal added Form Doctrine labels Jul 14, 2015

jakzal mentioned this issue Jul 14, 2015

[Form] Fix a BC break in the entity #15277

Merged

fabpot closed this as completed Jul 15, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[2.7] Expanded Entity Form Element with negative id values #15273

[2.7] Expanded Entity Form Element with negative id values #15273

Waigie commented Jul 14, 2015

jakzal commented Jul 14, 2015

Uh oh!

jakzal commented Jul 14, 2015

Uh oh!

Uh oh!

[2.7] Expanded Entity Form Element with negative id values #15273

[2.7] Expanded Entity Form Element with negative id values #15273

Comments

Waigie commented Jul 14, 2015

Example

Database Table

Code

jakzal commented Jul 14, 2015

Uh oh!

jakzal commented Jul 14, 2015

Uh oh!