Improving the Symfony Web Debug Toolbar and Profiler #15439
Comments
|
The ajax icon blinks till the request is over, personally I like this because you can see when it's still in progress of making the request. I think this is a nice feature and should remain as it is. |
|
In Symfony 2.7, debug toolbar and profiler shared the same design concepts (textured curved elements). Now that the toolbar got its new flat layout, shouldn't the profiler be adjusted to this look as well? At least the menu on the left side? |
|
@derrabus absolutely! That is the next planned step. We're already in the sketch and mockup phase. |
|
Awesome. :-) |
|
@derrabus we decided to make it in 2 separate PRs to make things easier to review and manage |
👍 |
|
I am also 👍 for keeping the blinking icon as an indicator. |
|
@javiereguiluz If the icon blinks even when all requests have finished, then this seems to be bug to me too. I just don't think it should stop blinking after a fixed time even if there are still requests being executed. |
|
👎 for keeping the blinking icon (all the time)... if you work with many ajax request like in a SPA you will never know when a request start or finished, is very bad :( |
This PR was squashed before being merged into the 2.8 branch (closes #16023). Discussion ---------- Minor fixes for the profiler and toolbar | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | partially #15439 | License | MIT | Doc PR | - Changes: * Fixed a misaligned icon * Changed the priorities of the collectors to better control their position and to leave a "gap" between priorities so custom panels can be displayed between the default panels. This idea came from @stof. By the way, @stof do you know how can I set the priority of the SwiftMailer collector? Its definition is the only one that doesn't use the `<tag name="data_collector" />`: ```xml <service id="swiftmailer.data_collector" class="%swiftmailer.data_collector.class%"> <argument type="service" id="service_container" /> </service> ``` https://github.com/symfony/swiftmailer-bundle/blob/master/Resources/config/swiftmailer.xml#L90-L92 Commits ------- bff4098 Minor fixes for the profiler and toolbar
|
Closing this because it's hard to work with "meta-issues" which last a long time. Most of the things listed originally have already been implemented. The others are either not essential or very hard to implement, so we'll deal with them in separate PRs. Thanks! |
…iluz) This PR was squashed before being merged into the 2.8 branch (closes symfony#16023). Discussion ---------- Minor fixes for the profiler and toolbar | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | partially symfony#15439 | License | MIT | Doc PR | - Changes: * Fixed a misaligned icon * Changed the priorities of the collectors to better control their position and to leave a "gap" between priorities so custom panels can be displayed between the default panels. This idea came from @stof. By the way, @stof do you know how can I set the priority of the SwiftMailer collector? Its definition is the only one that doesn't use the `<tag name="data_collector" />`: ```xml <service id="swiftmailer.data_collector" class="%swiftmailer.data_collector.class%"> <argument type="service" id="service_container" /> </service> ``` https://github.com/symfony/swiftmailer-bundle/blob/master/Resources/config/swiftmailer.xml#L90-L92 Commits ------- bff4098 Minor fixes for the profiler and toolbar
This is a meta-issue to list all the bugs and improvements related to the new Symfony toolbar and the new Symfony Profiler:
Toolbar
Bugs
Improvements
Profiler
Bugs
Improvements
[ ] [Exception] Use a dark theme for code snippets (reuse the work done in [WIP][DX] Better exception page #12363)[ ] [Security] Display the Roles as a list instead of inline JSONShow paramstoggle[ ] [General] Reconsider the colors used for the status banner. Now: 3xx HTTP = yellow, 4xx & 5xx = red, otherwise = green. Proposal: 3xx = green, 4xx = yellow, 5xx = red, otherwise = greenThe text was updated successfully, but these errors were encountered: