-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Stopwatch] Different behaviour if grouped with other tests #16405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oh, came across that yesterday too (3.0). Took me while to figure out it requires standalone run. I'd be for make these test independent on outer timings. Shall I prepare PR? |
It looks it's caused by one Symfony\HttpKernel test: https://github.com/symfony/symfony/blob/64917c726d2540bfe1d9f233cfaf04a4ebec5504/src/Symfony/Component/HttpKernel/Tests/Debug/TraceableEventDispatcherTest.php While digging deeper, it's dispatch() method in TraceableEventDispatcher. |
@TomasVotruba great job! Are you working on a PR? |
@jakzal I would love to, but I'm not exactly sure, why it's nulled. Got any idea? I'll try checking tonight. |
@TomasVotruba I didn't look into this yet as I wouldn't like to duplicate your efforts :) |
It looks like it's passing with:
but not with the custom script:
|
It looks like it's not passing with the custom script:
but my local phar file or vendor native PHPUnit binary:
Minimal changed <testsuites>
<testsuite name="Symfony Test Suite">
<directory>./src/Symfony/Component/HttpKernel/Tests/Debug/</directory>
<directory>./src/Symfony/Component/Stopwatch/*</directory>
</testsuite>
</testsuites> My PHP version is 5.6. |
I've tried to delete Could you retry @EmanueleMinotto ? |
@TomasVotruba sorry for the delay. Changing the testsuite (in the phpunit.xml.dist) to: <testsuites>
<testsuite name="Symfony Test Suite">
<directory>./src/Symfony/Component/HttpKernel/Tests/Debug/</directory>
<directory>./src/Symfony/Component/Stopwatch/*</directory>
</testsuite>
</testsuites> I have all green tests on every tests execution (also after just the git clone and composer install). |
@EmanueleMinotto did you delete the .phpunit folder the test using ./phpunit again? |
@nicolas-grekas yes, also removing the |
So, is there still an issue? You had a legacy .phpunit installation and the issue has gone now isn't it? |
For me it's gone. |
yes, it's solved for me too, thank you |
cool |
I don't know if this is related to #14444 or not, but everytime I try locally the tests (branch 2.8) related to the Stopwatch I have this behaviour:
The text was updated successfully, but these errors were encountered: