Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SymfonyStyle: Progress Bar Styling Logic Reversed ? #16577

Closed
@weaverryan

Description

@weaverryan

The SymfonyStyle::createProgressBar() currently looks like this:

    public function createProgressBar($max = 0)
    {
        $progressBar = parent::createProgressBar($max);
        if ('\\' === DIRECTORY_SEPARATOR) {
            $progressBar->setEmptyBarCharacter(''); // light shade character \u2591
            $progressBar->setProgressCharacter('');
            $progressBar->setBarCharacter(''); // dark shade character \u2593
        }
        return $progressBar;
    }

The \\ is a check to see if we're in Windows. So, these styles are only shown in Windows. Is that backwards?

Ping @kbond I think this line originally came from your commit - maybe you remember what the issue was.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions