Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecated choice_list option in ChoiceType? #16716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Nov 27, 2015 · 3 comments
Closed

Deprecated choice_list option in ChoiceType? #16716

nicolas-grekas opened this issue Nov 27, 2015 · 3 comments
Labels
Form

Comments

@nicolas-grekas
Copy link
Member

Do me miss a deprecation notice and a code update for this?

symfony/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php

Line 310 in 743e670

'choice_list' => null, // deprecated

@xabbuh xabbuh added the Form label Nov 27, 2015
@xabbuh
Copy link
Member

xabbuh commented Nov 27, 2015

It is deprecated in https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php#L257, but it seems we did not remove it entirely in #16075.

@webmozart
Copy link
Contributor

As @xabbuh said, it seems to be correctly deprecated in 2.8. I think we can remove it in 3.0 and move the code in the closure to a private createChoiceList() method instead.

@webmozart
Copy link
Contributor

see #16725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webmozart @nicolas-grekas @xabbuh