[Hack Day] Issue for newcomers (1) #18088

javiereguiluz · 2016-03-10T09:48:39Z

NOTE this issue has been prepared for the Virtual Symfony Hack Day which will take place on March 12th. Please, don't create a pull request for this issue before the Hack Day.

Introduction

This issue is exclusively for developers who have never contributed to Symfony. It's very easy to solve, so you just need to follow the contribution process to get it merged. Ryan Weaver (@weaverryan) will host a live video tutorial about this contribution process during the Virtual Hack Day. Meanwhile, you can read the Symfony Contribution Guide.

The problem to solve

In the Symfony 2.3 branch, locate the file src/Symfony/Component/HttpKernel/Profiler/Profiler.php.
In the collect() method there is a comment which wrongly uses the loose word instead of lose.

public function collect(Request $request, Response $response, \Exception $exception = null)
{
    // ...

    foreach ($this->collectors as $collector) {
        $collector->collect($request, $response, $exception);

        // forces collectors to become "read/only" (they loose their object dependencies)
        $profile->addCollector(unserialize(serialize($collector)));
    }

    return $profile;
}

The solution is to replace they loose their object dependencies by they lose their object dependencies.

The text was updated successfully, but these errors were encountered:

This PR was merged into the 2.3 branch. Discussion ---------- Profiler typo fix | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18088 | License | MIT | Doc PR | n/a Commits ------- 44398fc minor #18088 Fix typo for profiler

* 2.3: bumped Symfony version to 2.3.40 set s-maxage only if all responses are cacheable updated VERSION for 2.3.39 update CONTRIBUTORS for 2.3.39 updated CHANGELOG for 2.3.39 Improved the "branch" row of the PR table Fix typos #18090 1. PHPs session design to PHP's session design 2. Symfony HttpKernel offers to Symfony's HttpKernel offers 3. in which case it it should to in which case it should Fix for Isssue #18091 replace perfom by perform minor #18088 Fix typo for profiler

* 2.7: [PhpUnitBridge] Revert 7f62133 bumped Symfony version to 2.3.40 set s-maxage only if all responses are cacheable updated VERSION for 2.3.39 update CONTRIBUTORS for 2.3.39 updated CHANGELOG for 2.3.39 Improved the "branch" row of the PR table [Debug] Replaced logic for detecting filesystem case sensitivity [Process] Wait a bit less on Windows Use debug member variable Fix typos #18090 1. PHPs session design to PHP's session design 2. Symfony HttpKernel offers to Symfony's HttpKernel offers 3. in which case it it should to in which case it should Fix for Isssue #18091 replace perfom by perform minor #18088 Fix typo for profiler [ci] remove token for composer now that rate limiting is off Conflicts: src/Symfony/Bridge/PhpUnit/composer.json

* 2.8: [PhpUnitBridge] Revert 7f62133 bumped Symfony version to 2.3.40 set s-maxage only if all responses are cacheable updated VERSION for 2.3.39 update CONTRIBUTORS for 2.3.39 updated CHANGELOG for 2.3.39 Improved the "branch" row of the PR table [Debug] Replaced logic for detecting filesystem case sensitivity [Process] Wait a bit less on Windows Use debug member variable Autowiring the concrete class too - consistent with behavior of other services Fix typos #18090 1. PHPs session design to PHP's session design 2. Symfony HttpKernel offers to Symfony's HttpKernel offers 3. in which case it it should to in which case it should Fix for Isssue #18091 replace perfom by perform minor #18088 Fix typo for profiler [Validator] Fixing inaccurate typehint in docblock [ci] remove token for composer now that rate limiting is off Conflicts: CHANGELOG-2.3.md src/Symfony/Bridge/PhpUnit/composer.json

* 3.0: [PhpUnitBridge] Revert 7f62133 bumped Symfony version to 2.3.40 Fix leftover conflict marker in UPGRADE-3.0.md set s-maxage only if all responses are cacheable updated VERSION for 2.3.39 update CONTRIBUTORS for 2.3.39 updated CHANGELOG for 2.3.39 Improved the "branch" row of the PR table [Debug] Replaced logic for detecting filesystem case sensitivity [Process] Wait a bit less on Windows Use debug member variable Autowiring the concrete class too - consistent with behavior of other services Fix typos #18090 1. PHPs session design to PHP's session design 2. Symfony HttpKernel offers to Symfony's HttpKernel offers 3. in which case it it should to in which case it should Fix for Isssue #18091 replace perfom by perform minor #18088 Fix typo for profiler [Validator] Fixing inaccurate typehint in docblock [ci] remove token for composer now that rate limiting is off

javiereguiluz added the Hack Day label Mar 10, 2016

enleur mentioned this issue Mar 12, 2016

Profiler typo fix #18117

Merged

vladapopster mentioned this issue Mar 12, 2016

Fix type in collect() method comment #18122

Closed

NicolasNSSM mentioned this issue Mar 12, 2016

[HttpKernel] Fixed a typo in the collect() method of Profiler #18123

Closed

jjmonagas mentioned this issue Mar 12, 2016

[Hack Day] minor - Fix comment typo in the collect() method #18129

Closed

fabpot closed this as completed Mar 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hack Day] Issue for newcomers (1) #18088

[Hack Day] Issue for newcomers (1) #18088

javiereguiluz commented Mar 10, 2016

[Hack Day] Issue for newcomers (1) #18088

[Hack Day] Issue for newcomers (1) #18088

Comments

javiereguiluz commented Mar 10, 2016

Introduction

The problem to solve