Symfony 2.3 branch is not fully compatible with PHP 7. #18269

kalzekdor · 2016-03-23T03:10:10Z

There was a blog post on August 11th claiming that all maintained Symfony branches were 100% compatible with PHP 7. At the time, (and as of right now), 2.3 is a maintained branch.

However, if you view the code under the Debug section, you'll see that there is no support for the new Error type. Function typing should be using \Throwable, but instead are still using \Exception.

Which leads to errors like:

Whoops, looks like something went wrong.
1/1FatalErrorException: Error: Uncaught TypeError: Argument 1 passed to Symfony\Component\Debug\ExceptionHandler::handle() must be an instance of Exception, instance of Error given in ...\vendor\symfony\symfony\src\Symfony\Component\Debug\ExceptionHandler.php:67
Stack trace:

0 [internal function]: Symfony\Component\Debug\ExceptionHandler->handle(Object(Error))

1 {main}

thrown in ...\vendor\symfony\symfony\src\Symfony\Component\Debug\ExceptionHandler.php line 67
in ...\vendor\symfony\symfony\src\Symfony\Component\Debug\ExceptionHandler.php line 67

So... is 2.3 fully compatible with PHP 7 or not?

linaori · 2016-03-23T11:52:33Z

http://php.net/manual/en/language.errors.php7.php

I think it's 100% compatible, it just shouldn't catch the Errors here and delegate them most likely. All cases will work until you trigger something that would be an Error (Throwable) in php 7 but not in 5.*

kalzekdor · 2016-03-23T14:12:36Z

See the stack dump I included. When an Error type is thrown, ExceptionHandler is called and parameterized with the Error. This causes an Exception to be thrown there, which completely obiliterates any contextual information about the original Error (e.g., Stack Trace). Which makes any Errors thrown in PHP 7 nearly impossible to debug.

Exception handling in 2.3 has no provisions for handling the new Error type in PHP 7. Therefore, it would not be 100% compatible with PHP 7, as features are lost when switching to PHP 7.

The weird part is that, as far as I can tell, explicit handling for this exact scenario was implemented in the 2.6 branch, but was never back-ported to 2.3. But 2.3 is still in LTS, so the claim that all supported branches are fully compatible is false. It looks like someone just overlooked merging the changes into 2.3.

nicolas-grekas · 2016-03-23T14:16:11Z

@kalzekdor would you mind opening a PR against 2.3?

kalzekdor · 2016-03-23T14:24:32Z

@nicolas-grekas Sorry, I'm not too familiar with GitHub, so I'm not sure what you're asking for.

Here is a commit to the 2.6 branch that appears to address the issue, but as far as I can tell it was never applied to the 2.3 branch.

Simperfit · 2016-03-26T16:24:53Z

@kalzekdor @nicolas-grekas wanted to ask you if wou wanted to correct this issue by forking and working on that issue ;).

nicolas-grekas · 2016-03-28T09:10:34Z

Please check #18336

This PR was merged into the 2.3 branch. Discussion ---------- [Debug] Fix handling of php7 throwables | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18269 | License | MIT | Doc PR | - Should not be merged into 2.7 because 2.7 already has the required logic. Commits ------- b032096 [Debug] Fix handling of php7 throwables

kalzekdor · 2016-03-30T22:21:45Z

Great! Thanks @nicolas-grekas for the quick turn-around.

masterjus · 2017-04-19T12:53:49Z

Hello. It still doesn't work if I register only ExceptionHandler. Like ExceptionHandler::register();

stof · 2017-04-19T12:57:45Z

@masterjus 2.3 is not maintained anymore though

nicolas-grekas · 2017-04-19T13:02:53Z

ExceptionHandler needs to be used in conjunction with ErrorHandler, you should not (and cannot on PHP7) use it standalone.

mlivan · 2017-07-31T13:53:46Z

Symfony v2.4.10 also have problem with this bug.

xabbuh · 2017-07-31T15:01:55Z

Symfony 2.4 is not maintained anymore. You need to update to Symfony 2.7, 2.8, 3.2 or higher.

mlivan · 2017-08-01T06:15:42Z

Yes. Thank you.

chalasr · 2017-08-01T20:40:00Z

As of today 3.2 is not maintained anymore as well.

sterichards · 2018-05-10T15:57:37Z

I am having this issue on 2.7 using PHP 7.0.29 (cli)

curry684 · 2018-05-10T16:00:35Z

You are aware 2.7 is going out of active support in 3 weeks? You should urgently upgrade to 2.8 and then 3.4.

https://symfony.com/roadmap?version=2.7#checker

xabbuh · 2018-05-10T17:02:40Z

In any case, comments on closed issues are likely to get lost. Please open a new one with some steps on how to reproduce it.

ameenross · 2018-12-27T14:24:31Z

If you're still running something on Symfony 2.3 (I won't judge), this may cause you headaches. It seems the code in #18336 is just an incomplete hack.

When an E_NOTICE or anything else passes through the ErrorHandler, it's supposed to call the ExceptionHandler, which in turn serves the user with this:

The ErrorHandler does that by retrieving the ExceptionHandler first and then checking the below before finally calling the ExceptionHandler:

if (is_array($exceptionHandler) && $exceptionHandler[0] instanceof ExceptionHandler) {
}

Obviously, since the code in the referenced PR adds a closure as handler, this check evaluates to false. Therefore, no E_NOTICE, E_WARNING etc will ever be translated to an HTML page about the PHP error anymore.

javiereguiluz added Bug Unconfirmed Debug labels Mar 23, 2016

carsonbot added the Status: Needs Review label Mar 23, 2016

nicolas-grekas mentioned this issue Mar 28, 2016

[Debug] Fix handling of php7 throwables #18336

Merged

fabpot closed this as completed Mar 30, 2016

symfony locked as resolved and limited conversation to collaborators Dec 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Symfony 2.3 branch is not fully compatible with PHP 7. #18269

Symfony 2.3 branch is not fully compatible with PHP 7. #18269

kalzekdor commented Mar 23, 2016

0 [internal function]: Symfony\Component\Debug\ExceptionHandler->handle(Object(Error))

1 {main}

linaori commented Mar 23, 2016

kalzekdor commented Mar 23, 2016

nicolas-grekas commented Mar 23, 2016

kalzekdor commented Mar 23, 2016

Simperfit commented Mar 26, 2016

nicolas-grekas commented Mar 28, 2016

kalzekdor commented Mar 30, 2016

masterjus commented Apr 19, 2017

stof commented Apr 19, 2017

nicolas-grekas commented Apr 19, 2017 •

edited

Loading

mlivan commented Jul 31, 2017

xabbuh commented Jul 31, 2017

mlivan commented Aug 1, 2017

chalasr commented Aug 1, 2017

sterichards commented May 10, 2018

curry684 commented May 10, 2018

xabbuh commented May 10, 2018

ameenross commented Dec 27, 2018

Symfony 2.3 branch is *not* fully compatible with PHP 7. #18269

Symfony 2.3 branch is *not* fully compatible with PHP 7. #18269

Comments

kalzekdor commented Mar 23, 2016

0 [internal function]: Symfony\Component\Debug\ExceptionHandler->handle(Object(Error))

1 {main}

linaori commented Mar 23, 2016

kalzekdor commented Mar 23, 2016

nicolas-grekas commented Mar 23, 2016

kalzekdor commented Mar 23, 2016

Simperfit commented Mar 26, 2016

nicolas-grekas commented Mar 28, 2016

kalzekdor commented Mar 30, 2016

masterjus commented Apr 19, 2017

stof commented Apr 19, 2017

nicolas-grekas commented Apr 19, 2017 • edited Loading

mlivan commented Jul 31, 2017

xabbuh commented Jul 31, 2017

mlivan commented Aug 1, 2017

chalasr commented Aug 1, 2017

sterichards commented May 10, 2018

curry684 commented May 10, 2018

xabbuh commented May 10, 2018

ameenross commented Dec 27, 2018

Symfony 2.3 branch is not fully compatible with PHP 7. #18269

Symfony 2.3 branch is not fully compatible with PHP 7. #18269

nicolas-grekas commented Apr 19, 2017 •

edited

Loading