-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Improve console header line #19095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
At least for the |
@xabbuh any thoughts? Im just playing around with it.. not sure if this is it though. Some things i like (kernel@env format, better signal colors), some things i dont (colors 😅, brackets i guess =/) Trick/ugly part is the debug thingy imo, but i kinda like this till that. |
In my opinion the latest proposal is more confusing than the existing line. We could go for the explicit way:
|
I think |
I know.. therefore i proposed on/off instead of true/false. Imho red/green also signals on/off. But maybe keeping it simple is a good thing, ie plain text except for the version. edit: |
This is not supported by Windows terminals. |
What if we don't use color at all? If not possible, please don't try to convey the information with colors. Color blindness, specially for green/red, is very common for humans: ~8% of males suffer it (but only 0.5% of females) see reference |
Globally? The whole console is pretty colorful right now and can be controlled by Or do you propose
You mean "If possible" right? |
I you really want to use colours here, I would use them to distinguish keys and values, but I would not use a colour that is dependent on the actual value. |
Agreed with @xabbuh since using colors this way can make parentheses needless |
My preference would be the third option. |
Mine too :) Btw, would it make sense to let it interact with output verbosity? I.e. |
…ting (ro0NL) This PR was squashed before being merged into the 3.2-dev branch (closes #19275). Discussion ---------- [Console][FrameworkBundle] Revised console header formatting | Q | A | ------------- | --- | Branch? | "master" | Bug fix? | no | New feature? | yes (ui change) | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | #19095 | License | MIT | Doc PR | reference to the documentation PR, if any Before/After  Commits ------- fcddb3a [Console][FrameworkBundle] Revised console header formatting
Uh oh!
There was an error while loading. Please reload this page.
Hi,
Imho the current header line for the console application is a bit circus-like and misleading.
Circus like as in; Green, white and yellow for the name/version part.
Misleading as in
app/dev/debug
looking like a working directory or at least some sort of path.Im not proposing a big fat ascii header here, but just some formatting improvements. What about formatting the individual parts (version, kernel name, dev yes/no, debug yes/no) as labels, a bit like the webprofiler toolbar is doing.
The text was updated successfully, but these errors were encountered: