Thanks to visit codestin.com
Credit goes to github.com

Skip to content

3.2 - DateIntervalType - 'invert' should not inherit the 'required' option" #20876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
galeaspablo opened this issue Dec 12, 2016 · 0 comments
Closed

3.2 - DateIntervalType - 'invert' should not inherit the 'required' option" #20876

galeaspablo opened this issue Dec 12, 2016 · 0 comments
Labels
Bug Form Status: Needs Review
Milestone
3.2

Comments

@galeaspablo
Copy link
Contributor

In the DateIntervalType, there is a field, called 'invert', that allows for negative intervals.
This is outputted as a checkbox. Which is fine, but it shouldn't be required.

To reproduce?
Use the new DateIntervalType in Symfony 3.2
Set required=true, the field 'invert' will inherit the required option.
@galeaspablo galeaspablo mentioned this issue Dec 12, 2016
Closed
@xabbuh xabbuh added this to the 3.2 milestone Dec 12, 2016
@ogizanagi ogizanagi mentioned this issue Dec 12, 2016
Merged
fabpot added a commit that referenced this issue Dec 13, 2016
@fabpot
bug #20877 DateIntervalType: 'invert' should not inherit the 'require…
0daa64f 
…d' option (galeaspablo)

This PR was squashed before being merged into the 3.2 branch (closes #20877).

Discussion
----------

DateIntervalType: 'invert' should not inherit the 'required' option

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20876
| License       | MIT
| Doc PR        | -

As explained in #20876,

> In the DateIntervalType, there is a field, called 'invert', that allows for negative intervals. This is outputted as a checkbox. Which is fine, but it shouldn't be required.

Commits
-------

b1597f1 DateIntervalType: 'invert' should not inherit the 'required' option
@fabpot fabpot closed this as completed Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Needs Review
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
4 participants
@fabpot @xabbuh @galeaspablo @carsonbot