Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Errors on HHVM LTS 3.18 #21900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
photodude opened this issue Mar 6, 2017 · 4 comments
Closed

Errors on HHVM LTS 3.18 #21900

photodude opened this issue Mar 6, 2017 · 4 comments

Comments

@photodude
Copy link

Q A
Bug report? yes
Feature request? no
BC Break report? yes/no
RFC? no
Symfony version master branch

the following errors occurred on the current HHVM LTS 3.18

syntax error, unexpected '{', expecting $end or TC_SECTION or TC_LABEL or END_OF_LINE in /home/travis/build/symfony/symfony/src/Symfony/Component/DependencyInjection/Tests/Fixtures/ini/nonvalid.ini on line 1

syntax error, unexpected JUNK in /home/travis/build/symfony/symfony/src/Symfony/Component/DependencyInjection/Tests/Fixtures/ini/almostvalid.ini on line 1

Fatal error: Class already declared: appFrameworkbundletestsessionDebugProjectContainer in /tmp/3.3.0-DEV/Session/cache/frameworkbundletestsession/appFrameworkbundletestsessionDebugProjectContainer.php on line 20

see build
https://travis-ci.org/symfony/symfony/jobs/208295490

note: test does not complete more than 96% and thus does not report the additional errors
@photodude photodude mentioned this issue Mar 6, 2017
Closed
@fabpot
Copy link
Member

fabpot commented Mar 6, 2017

Do you want to work on fixes for those errors? HHVM is not actively maintained by the core team, but we are more than happy to merge PRs to fix problems.

@photodude
Copy link
Author

I will if I can figure out the issues. Not sure my skills are up to that, or when I will have some time to attempt to dig into the details.

@photodude photodude mentioned this issue Mar 6, 2017
Closed
@fabpot
Copy link
Member

fabpot commented Mar 6, 2017

@photodude Thank you.

@nicolas-grekas nicolas-grekas mentioned this issue Mar 7, 2017
Merged
nicolas-grekas added a commit that referenced this issue Mar 7, 2017
@nicolas-grekas
minor #21914 [travis] Master fixes for HHVM 3.18LTS (nicolas-grekas)
2a239fc 
This PR was merged into the 3.3-dev branch.

Discussion
----------

[travis] Master fixes for HHVM 3.18LTS

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21900
| License       | MIT
| Doc PR        | -

For some reason, the current HHVM 3.15 consistently crashes in its shutdown sequence on master.
Time to move to 3.18?

https://github.com/symfony/symfony/pull/21914/files?w=1

Commits
-------

114d62c [travis] Master fixes for HHVM 3.18LTS
@nicolas-grekas nicolas-grekas mentioned this issue Mar 7, 2017
Closed
@nicolas-grekas
Copy link
Member

Fixes done in https://github.com/symfony/symfony/pull/21917/files?w=1 :)

This was referenced Mar 8, 2017
Merged
Merged
fabpot added a commit that referenced this issue Mar 8, 2017
@fabpot
bug #21923 [travis] Test with hhvm 3.18 (nicolas-grekas)
a0945fc 
This PR was merged into the 2.7 branch.

Discussion
----------

[travis] Test with hhvm 3.18

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21900
| License       | MIT
| Doc PR        | -

Needs #21922 on master to be green also.
Works around  facebook/hhvm#7722.

Commits
-------

7f1f0cb [travis] Test with hhvm 3.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @nicolas-grekas @photodude