Can you confirm that the change from #24223 applied on the compiler pass in your code base solves the issue?

@xabbuh thank you for participating, but, unfortunatelly, that fix does not help.

Changing getDefinition to findDefinition forces AddConstraintValidatorsPass to find decorator service, not a decorated service. As a result, compiler pass replaces argument on a decorator (custom class, which expects to original service as a first argument), not on original service.

The issue is that the AddConstraintValidatorPass is registered as TYPE_BEFORE_REMOVING, which runs after the decoration.

Btw, this can also cause other bugs, because it also runs after optimizations while it is adding new links in the graph, which may forbid some optimizations already applied.
@fabpot you are the one moving it later in #20116. Why was it done ?

@stof I am also often register my passes as TYPE_BEFORE_REMOVING, because I am often experience an issue, when service tries to collect other services before they appears in container.

For example, I have own "autowire" pass, which registers new services in TYPE_BEFORE_OPTIMIZATION stage, and, depends on bundles order, collecting by tags pass runs before "autowiring" pass. So, I forced to move my collecting pass later, to TYPE_OPTIMIZE or TYPE_BEFORE_REMOVING

So, maybe we could have TYPE_COLLECT_TAGS stage?

So, currently I solved the issue by writing custom CompilerPass, which performs decoration on TYPE_BEFORE_REMOVING stage (my bundle registered after FrameworkBundle, so it helps). Btw, issue still exists.

@Strate if you add new references after the optimizations, you may break your container entirely due to optimizations being wrong.

What you should do is register your "autowire" pass creating new services with a priority higher than 0, so that it runs at the beginning of TYPE_BEFORE_OPTIMIZATION stage.

@stof default \Symfony\Component\DependencyInjection\Compiler\AutowirePass is registered in TYPE_OPTIMIZE stage, is it okay?

Btw, I think we need to document it.

@fabpot Can you answer @stof's question from #24222 (comment)? :)

@xabbuh @stof I don't remember, sorry.