Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DI] 3.4 BC Break - all my services made private #24465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Strate opened this issue Oct 6, 2017 · 7 comments
Closed

[DI] 3.4 BC Break - all my services made private #24465

Strate opened this issue Oct 6, 2017 · 7 comments
Labels
BC Break Bug DependencyInjection Status: Needs Review Unconfirmed

Comments

@Strate
Copy link
Contributor

Strate commented Oct 6, 2017

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.4.x-dev

I tried to upgrade from 3.3 to 3.4.x-dev to test compatibility and found that all of my services made private by default. It happes from Symfony\Component\DependencyInjection\Compiler\ResolveChildDefinitionsPass::process method:

foreach ($container->getDefinitions() as $definition) {
    if ($definition->isPrivate()) {
        $definition->setPublic(false);
        $definition->setPrivate(true);
    }
}

->isPrivate() method returns true for all services by default, because \Symfony\Component\DependencyInjection\Definition::$private set as true by default.

/cc @nicolas-grekas
@nicolas-grekas
Copy link
Member

What the behavior you have? Any error message?

@Strate
Copy link
Contributor Author

Strate commented Oct 6, 2017

I have my custom CompilerPass which checks for isPublic and fails if it is falsy (this need for custom services collection by tags)

@stof
Copy link
Member

stof commented Oct 6, 2017

@Strate 4.0 will make services private by default. If you don't specify the visibility of services, 3.4 will indeed make them semi-private in this case: it will treat them as private, but ensure that they cannot be removed or inlined, so that they are still accessible in Container::get() thanks to the BC layer.
Note that in most cases, new Symfony DI 3.3 features (especially IteratorArgument and ServiceLocator) make it possible to avoid the need to use public services for lazy references.

@nicolas-grekas should we do this change on setPublic at a lower priority than at the beginning of priority 0 compiler passes ? It is common for bundles to check for isPublic in their compiler passes, and this would indeed not work well here when relying on the BC layer.

@Strate
Copy link
Contributor Author

Strate commented Oct 6, 2017

@stof thank you, I've got a reason why it was done. I will definitely refactor my code for sf4

@nicolas-grekas nicolas-grekas mentioned this issue Oct 6, 2017
Merged
@nicolas-grekas
Copy link
Member

@Strate maybe you should run your pass BEFORE_OPTIMIZATION? It's strange to run a check at OPTIMIZATION step, isn't it?
@stof did you mean something like #24468?

@Strate
Copy link
Contributor Author

Strate commented Oct 6, 2017

It's strange to run a check at OPTIMIZATION step, isn't it?

Yes, I think so too, but there is a reason to run it there: my compiler pass should run after ResolveDefinitionTemplates pass, and long time ago (when symfony was at version 2) I decided to just move my compiler pass to OPTIMIZATION step.

@Strate
Copy link
Contributor Author

Strate commented Oct 6, 2017 •
edited
Loading

@nicolas-grekas there is even such compiler pass in Symfony core: #20116

fabpot added a commit that referenced this issue Oct 10, 2017
@fabpot
bug #24468 [DI] Turn private defs to non-public ones before removing …
7f899a9 
…passes (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Turn private defs to non-public ones before removing passes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24465
| License       | MIT
| Doc PR        | -

As spotted by @stof in #24465 (comment).

Commits
-------

e5d0934 [DI] Turn private defs to non-public ones before removing passes
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this issue Oct 10, 2017
@fabpot
bug #24468 [DI] Turn private defs to non-public ones before removing …
a83fd9d 
…passes (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Turn private defs to non-public ones before removing passes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24465
| License       | MIT
| Doc PR        | -

As spotted by @stof in symfony/symfony#24465 (comment).

Commits
-------

e5d0934b87 [DI] Turn private defs to non-public ones before removing passes
@fabpot fabpot closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Bug DependencyInjection Status: Needs Review Unconfirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @javiereguiluz @nicolas-grekas @Strate @stof @carsonbot