[Solved] For some reason twig dump (Twig_Extension_Debug) extension from 3.4.5 is more important that var-dumper. IMO it can be treated as BC break.

We had Twig_Extension_Debug enabled in project and so far it was ignored. From 3.4.5 it's loaded instead var-dumper.

services:
    twig.extension.debug:
        class: Twig_Extension_Debug
        tags:
                - { name: 'twig.extension' }

Maybe it's connected to #25756 ?

Can you create a small example project that allows to reproduce your issue?

Hey, you need repo with example? It's very simple i reproduce it with:

symfony new test_dump 3.4.4 in app/Resources/views/base.html.twig i added {{ dump(app.request) }}. Then in app/config/services.yml i added to services section:

    twig.extension.debug:
        class: Twig_Extension_Debug
        tags:
                - { name: 'twig.extension' }

Now it renders dump ok. When i change in composer.json "symfony/symfony": "3.4.4", to "symfony/symfony": "3.4.5", and call composer update --prefer-dist --prefer-stable after installation dump is wrong (rendered by Twig_Extension_Debug). Looks like with var-dump we don't need this extension anymore, but it SF shouldn't change so much in minor release.

Status: Reviewed

Indeed, @ahilles107 is right. I tested it.

Twig_Extension_Debug extension and Symfony\Bridge\Twig\Extension\DumpExtension extension both define the Twig dump function.
Before #25756, Twig_Extension_Debug was initialized first, so the dump function was replaced when Symfony\Bridge\Twig\Extension\DumpExtension was loaded just after.
Now it's just the contrary.

BTW, the output you get now is normal since the Twig_Extension_Debug extension dump function is basically a var_dump. That's the "ugly" thing we had before the VarDumper component ^^

Also, I'm not sure if it can be considered as a true BC break, since the Twig_Extension_Debug extension dump function was simply never used before in your case. It looks like a wrong usage. Or maybe am I missing something ?

@fancyweb - you are right, we don't use Twig_Extension_Debug in this project from long time but it was still declared in services (our fault). But we talk here about minor release and changed behaviour of framework.

And it's quite hard to debug as it looks like some new simple formatter in VarDumper as nothing changed in the place where it's called. I started checking this from reading VarDumper, twig, and bridges changelogs.

About the BC break, it is one. There is no doubt about it. However, I have learned that when you use Symfony, if your code is working by chance and that it breaks later as a side effect of something else, it might not always be considered as true BC break. Let's wait for a member opinion.

To me it's a BC break too.

Can I take this one?

@pmontoya please do!

Hey, any progress here @pmontoya?

@ahilles107 Why don't you just remove your "twig.extension.debug" service ?

@fancyweb i solved it in first comment to this issue. But it's still BC'break, and I'm looking at this issue from time to time.

@pmontoya are you still interested in fixing this bug ... or do you prefer to "release" it so others can take it over? Thanks!

@javiereguiluz : Sorry, I forgot this issue. I'll work on it tomorrow.

I'm sorry but without using the 4.1 feature with twig extension priority, I don't see how to fix this BC Break without removing #25756 changes

That's what I'm trying to say since the beginning of this issue. Also does it really worth it to fix this regression 18 patches versions later ? 🤔

@nicolas-grekas @fancyweb what can we do about this ?