-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
symfony/form DateTimeType label=false doesn't work #28198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@steevanb Can you create a small example project that allows to reproduce your issue? I was not able to reproduce: |
Just show generated source code, and you will see label is "hidden" by inputs. Not showned, but written and hidden. |
Hm indeed, for the Boostrap form theme that's true. But is that really an issue if the labels are not shown anyway? |
This seems to have been introduced with the base bootstrap form theme file when support for Bootstrap 4 was added. |
… false (xabbuh) This PR was merged into the 4.1 branch. Discussion ---------- [Form][TwigBridge] fix not displaying labels when value is false | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28198 | License | MIT | Doc PR | Commits ------- c4a6c9f fix not displaying labels when value is false
Symfony version(s) affected: 3.4 (not tested on 4.x)
Description
DateTimeType doe not take into account
label
configuration :false
, labels are shownedfoo
,Year
Month
Day
Hour
Minute
are shownedMaybe
DateType
andTimeType
have same behavior.How to reproduce
Possible Solution
https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Form/Extension/Core/Type/DateType.php#L111
Fill $yearOptions, $monthOptions and $dayOptions with our
label
configuration, instead of justrequired
andtranslation_domain
Additional context
No additional context
The text was updated successfully, but these errors were encountered: