Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UrlType are always changed to text types #31283

Closed
@lmlsna

Description

@lmlsna

Symfony version(s) affected: 4.1.11 +

Description
Both of these PRs were merged:
#29926 = Changed UrlType input type to text when default_protocol is not null
wallabag/wallabag#3879 = Force default_protocol to generate an url input

So now we are forcing a default protocol, AND changing the type to text if there's a default protocol (which there always is, because we force it).

So this element never renders as a type="url" now. And because it writes to the $view var "type", we have no way to override that.

It doesn't make much sense to change a UrlType to a TextType, and the inputmode attribute was obsoleted in the WC5.2. If you just remove that bit, it works like all the other extended text types.

How to reproduce
Create a UrlType form element.

Possible Solution
I can send a PR fixing this by not forcing a type="text" anymore in Symfony\Component\Form\Extension\Core\Type\UrlType

Additional context

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions