-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[RFC] Give back control of password hashing algorithm to app developer #33054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This comment has been minimized.
This comment has been minimized.
For some background on how this would be a problem, see #28093 |
How is this an alternative to auto? Spring recommends exactly the same as the new option to me. |
@nicolas-grekas The difference with the |
See |
But which are the encoders we can use with For example, I want to be able to use |
@nicolas-grekas |
I also think that using something else that |
Implementation wise, this should be a new constructor argument to native/sodium encoders. |
I'm on it. |
Description
(From #30914 (comment), #30914 (comment), #30914 (comment))
I think what's still very disturbing to me is that the app developer will completely lose control over which password hashing algorithm to use.
What's worse, if you have a scenario where you upgrade your PHP version / sodium extension and a new algorithm becomes supported, then if you rollback the app, the password would then fail to verify. There is no way to prevent this from happening if the app developer is forced to use
auto
.TL;DR:
auto
is a good default, but choice is good (and sometimes necessary).Example
The text was updated successfully, but these errors were encountered: