Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RFC] Mark CompositeConstraint as internal? #34830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Dec 5, 2019 · 1 comment · Fixed by #34856
Closed

[RFC] Mark CompositeConstraint as internal? #34830

javiereguiluz opened this issue Dec 5, 2019 · 1 comment · Fixed by #34856
Labels
RFC RFC = Request For Comments (proposals about features that you want to be discussed) Validator
Milestone
5.1

Comments

@javiereguiluz
Copy link
Member

Description
We discussed about this at symfony/symfony-docs#10381 and @xabbuh wondered if we should mark CompositeConstraint as internal.
@javiereguiluz javiereguiluz added Validator RFC RFC = Request For Comments (proposals about features that you want to be discussed) labels Dec 5, 2019
@javiereguiluz javiereguiluz added this to the next milestone Dec 5, 2019
@javiereguiluz javiereguiluz mentioned this issue Dec 5, 2019
Closed
@stof
Copy link
Member

stof commented Dec 5, 2019

I think this makes sense. I don't think this was ever meant to be used for custom constraints.

@xabbuh xabbuh mentioned this issue Dec 6, 2019
Merged
@fabpot fabpot closed this as completed in 24ed8e1 Dec 7, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC RFC = Request For Comments (proposals about features that you want to be discussed) Validator
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

[Validator] mark the Composite constraint as internal xabbuh/symfony
3 participants
@javiereguiluz @nicolas-grekas @stof