Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PHPUnitBridge] ExpectDeprecationTrait::expectDeprecation() conflicts with TestCase::expectDeprecation() #37133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phansys opened this issue Jun 7, 2020 · 0 comments
Closed

[PHPUnitBridge] ExpectDeprecationTrait::expectDeprecation() conflicts with TestCase::expectDeprecation() #37133

phansys opened this issue Jun 7, 2020 · 0 comments
Labels
Bug PhpUnitBridge Status: Needs Review

Comments

@phansys
Copy link
Contributor

phansys commented Jun 7, 2020

Symfony version(s) affected: 5.1.0

Description

ExpectDeprecationTrait::expectDeprecation() conflicts with TestCase::expectDeprecation(), which was introduced in phpunit/phpunit:8.4.0.

How to reproduce

Use SYMFONY_PHPUNIT_VERSION=8.4.0.

Possible Solution

Update the method name, like suggested at #35192 (comment).
@phansys phansys added the Bug label Jun 7, 2020
@phansys phansys mentioned this issue Jun 7, 2020
Closed
5 tasks
@fancyweb fancyweb mentioned this issue Jun 8, 2020
Merged
fabpot added a commit that referenced this issue Jun 10, 2020
@fabpot
bug #37153 [PhpUnitBridge] Fix ExpectDeprecationTrait::expectDeprecat…
5cefcc2 
…ion() conflict (fancyweb)

This PR was merged into the 5.1 branch.

Discussion
----------

[PhpUnitBridge] Fix ExpectDeprecationTrait::expectDeprecation() conflict

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #37133
| License       | MIT
| Doc PR        | -

ExpectDeprecationTrait::expectDeprecation() must be compatible with TestCase::expectDeprecation(). I'm personally against a renaming on our side because this name is the best.

Commits
-------

ea5bb24 [PhpUnitBridge] Fix ExpectDeprecationTrait::expectDeprecation() conflict
@fabpot fabpot closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @phansys @xabbuh @carsonbot