Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Messenger] BC break in SF 5.0 for stamps due to changes stamp classes #37616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tobion opened this issue Jul 20, 2020 · 1 comment
Closed

[Messenger] BC break in SF 5.0 for stamps due to changes stamp classes #37616

Tobion opened this issue Jul 20, 2020 · 1 comment
Labels
Bug Messenger Status: Needs Review

Comments

@Tobion
Copy link
Contributor

Tobion commented Jul 20, 2020

Symfony version(s) affected: >=5.0

Description
Moving the transports to separate packages in #35422 broke BC for the stamps.

How to reproduce
Using the deprecated classes to fetch stamps does not work anymore since the stamps are now added to the envelope using the new classes. So this code $envelope->last(\Symfony\Component\Messenger\Transport\AmqpExt\AmqpReceivedStamp::class); does not find the stamp anymore.

Possible Solution
Duplicate the stamps in the evelope with the new class and deprecated classes. Or add some logic in the retrieving methods to know about new and old class names.
@Tobion Tobion added the Bug label Jul 20, 2020
@Tobion Tobion mentioned this issue Jul 20, 2020
Merged
@ogizanagi ogizanagi mentioned this issue Aug 13, 2020
Merged
@ogizanagi
Copy link
Contributor

#37826 should do it

@fabpot fabpot closed this as completed Aug 17, 2020
fabpot added a commit that referenced this issue Aug 17, 2020
@fabpot
bug #37826 [Messenger] Fix BC layer for stamps moved into separate pa…
fe5021e 
…ckages (ogizanagi)

This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] Fix BC layer for stamps moved into separate packages

| Q             | A
| ------------- | ---
| Branch?       | 5.1 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #37616 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

118579c [Messenger] Fix BC layer for stamps moved into separate packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @Tobion @ogizanagi @carsonbot