[DI] The generated code for lazy non-shared services doesn't work #38327

surikman · 2020-09-28T07:43:19Z

Symfony version(s) affected: >=5.1.3

Description
When a service is declared as lazy and non-shared, generated code uses $this->factories['service_name'](false); inside proxy without initialization of $this->factories['service_name'] before.

How to reproduce

class MyClass {}

$container = new ContainerBuilder();

$container->register('non_shared_foo', MyClass::class)->setShared(false)->setLazy(true)->setPublic(true);
$container->compile();

$dumper = new PhpDumper($container);
$dumper->setProxyDumper(new ProxyDumper());

print_r($dumper->dump(['as_files' => false]));

The generated getNonSharedFooService looks like this:

protected function getNonSharedFooService($lazyLoad = true)
{
    if ($lazyLoad) {
        return $this->createProxy('MyClass_c5258b3', function () {
            return \MyClass_c5258b3::staticProxyConstructor(function (&$wrappedInstance, \ProxyManager\Proxy\LazyLoadingInterface $proxy) {
                $wrappedInstance = $this->factories['non_shared_foo'](false);

                $proxy->setProxyInitializer(null);

                return true;
            });
        });
    }

    $this->factories['non_shared_foo'] = function ($lazyLoad = true) {
        return new \MyClass();
    };

    return $this->factories['non_shared_foo']();
}

Possible Solution
This bug comes from this commit - symfony/dependency-injection@37d0137 (#37435)
when I change back this

$factoryCode = $definition->isShared() ? ($asFile ? "\$this->load('%s', false)" : '$this->%s(false)') : '$this->factories[%2$s](false)';

to this

$factoryCode = $asFile ? "\$this->load('%s', false)" : '$this->%s(false)';

it works well.

The text was updated successfully, but these errors were encountered:

stof · 2020-09-28T09:03:30Z

/cc @nicolas-grekas

This PR was merged into the 5.1 branch. Discussion ---------- [DI] fix dumping non-shared lazy services | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #38327 | License | MIT | Doc PR | - It took me a while to get this correct, but here we are. Commits ------- e33a0b0 [DI] fix dumping non-shared lazy services

vkurdin-aw · 2021-03-30T12:18:20Z

@nicolas-grekas
Look like this is also reproducible on 4.4.21.
The reproduce-snippet from OP is generating correct code. But compiled code from real project is still affected.

services.yml:

    Acme\FooClass:
        public: true
        lazy: true
        shared: false

getFooClassService.php:

use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
use Symfony\Component\DependencyInjection\Exception\RuntimeException;

// This file has been auto-generated by the Symfony Dependency Injection Component for internal use.
// Returns the public 'Acme\FooClass' service.

if ($lazyLoad) {
    return $this->createProxy('FooClass_704b59e', function () {
        return \FooClass_704b59e::staticProxyConstructor(function (&$wrappedInstance, \ProxyManager\Proxy\LazyLoadingInterface $proxy) {
            $wrappedInstance = $this->factories['Acme\\FooClass'](false);

            $proxy->setProxyInitializer(null);

            return true;
        });
    });
}

include_once \dirname(__DIR__, 4).'/Acme/FooClass.php';

$this->factories['Acme\\FooClass'] = function ($lazyLoad = true) {
    return new \Acme\FooClass();
};

return $this->factories['Acme\\FooClass']();

nicolas-grekas · 2021-03-30T12:25:22Z

@vkurdin-aw can you please open a new issue with a reproducer?

vkurdin-aw · 2021-03-30T16:19:10Z

@nicolas-grekas done #40642

surikman added the Bug label Sep 28, 2020

carsonbot added the Status: Needs Review label Sep 28, 2020

stof added the DependencyInjection label Sep 28, 2020

nicolas-grekas mentioned this issue Sep 30, 2020

[DI] fix dumping non-shared lazy services #38357

Merged

fabpot closed this as completed Oct 1, 2020

vkurdin-aw mentioned this issue Mar 30, 2021

The generated code for lazy non-shared services doesn't work #40642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DI] The generated code for lazy non-shared services doesn't work #38327

[DI] The generated code for lazy non-shared services doesn't work #38327

surikman commented Sep 28, 2020 •

edited

Loading

stof commented Sep 28, 2020

vkurdin-aw commented Mar 30, 2021

nicolas-grekas commented Mar 30, 2021

vkurdin-aw commented Mar 30, 2021

[DI] The generated code for lazy non-shared services doesn't work #38327

[DI] The generated code for lazy non-shared services doesn't work #38327

Comments

surikman commented Sep 28, 2020 • edited Loading

stof commented Sep 28, 2020

vkurdin-aw commented Mar 30, 2021

nicolas-grekas commented Mar 30, 2021

vkurdin-aw commented Mar 30, 2021

surikman commented Sep 28, 2020 •

edited

Loading