Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Symfony LDAP testing #39028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucasaba opened this issue Nov 7, 2020 · 4 comments
Closed

Symfony LDAP testing #39028

lucasaba opened this issue Nov 7, 2020 · 4 comments
Labels
Bug Ldap Status: Needs Review

Comments

@lucasaba
Copy link
Contributor

lucasaba commented Nov 7, 2020

Symfony version(s) affected: 4.4.* and following

Description
LDAP test are never run.

How to reproduce
ALL test are skipped when no LDAP server is reachable. And no LDAP is provided in github actions, Travis CI and in AppVeyor.

Possible Solution
Add an OpenLDAP server in Github Actions

Additional context
I'm developing on a separate branch a possible solution. The branch is this: https://github.com/lucasaba/symfony/tree/add-ldap-tests

It already adds some of the proposed solution from @Nek- in #38875
It adds an external dependency on an openldap docker image that I'm trying to avoid but... with no luck.
Using this information I was able to run almost all test and to correct some problem on them.

I'm working on fixing a strange error when dealing with PHP 7.1: "Crtitical extension unavilable". As soon as I've fixed that, I'll made a PR.

Any help to avoid dealing with my personal docker image for openldap on github actions would be gratly appreciated.
@lucasaba lucasaba added the Bug label Nov 7, 2020
@lucasaba lucasaba mentioned this issue Nov 7, 2020
Merged
@wouterj
Copy link
Member

wouterj commented Nov 7, 2020

Travis does include some set-up for openldap. So I'm not sure why they are skipped, but it seems there at least was an intention to test ldap on Travis.

symfony/.travis.yml

Lines 102 to 106 in 67948a7

mkdir /tmp/slapd
if [ ! -e /tmp/slapd-modules ]; then
[ -d /usr/lib/openldap ] && ln -s /usr/lib/openldap /tmp/slapd-modules || ln -s /usr/lib/ldap /tmp/slapd-modules
fi
slapd -f src/Symfony/Component/Ldap/Tests/Fixtures/conf/slapd.conf -h ldap://localhost:3389 &

@lucasaba
Copy link
Contributor Author

lucasaba commented Nov 7, 2020 •
edited
Loading

I think symfony is moving on github actions. At least that's what I could understand from @nicolas-grekas response.

But I can have a look at Travis too.

@derrabus
Copy link
Member

derrabus commented Nov 7, 2020

We've shifted integration tests to GHA, so testing LDAP on GHA sounds reasonable.

@wouterj
Copy link
Member

wouterj commented Nov 7, 2020

Yes, I think it's fine to "move" ldap integration tests to github actions. We should then remove the travis ldap set-up I think (that might also improve Travis performance a bit).

@Nyholm Nyholm added the Ldap label Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Ldap Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lucasaba @wouterj @Nyholm @derrabus @carsonbot