Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[RFC] Make masterminds/html5 a required dependency of dom-crawler #43341

Closed
@stof

Description

@stof

Description
The DomCrawler has an optional integration with masterminds/html5 to provide a better parsing of HTML5 (the DOMDocument::loadHTML method is based on the HTML4 spec, not the HTML5 one, and so has many issues when using HTML5 features) when the library is available.
Given the frequency of bug reports we get about broken parsing in dom-crawler, I'm wondering whether we should make masterminds/html5 a required dependency instead of an optional one, so that any HTML using the HTML5 doctype is always parsed using the HTML5 parser.
If the decision is a yes, the next question is which version should do that switch.

What do you think about that ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    DomCrawlerRFCRFC = Request For Comments (proposals about features that you want to be discussed)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions