[Messenger] option --no-reset on messenger:consume is broken #46349
Labels
Comments
fabpot
added a commit
that referenced
this issue
Jun 12, 2022
… listener (Thomas Talbot) This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] move resetting services at worker stopped into listener | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46349 | License | MIT This PR tries to fix an issue about "--no-reset" introduced by a [previous fix](a4c8f4e). Instead of resetting the resettable receivers after the WorkerStoppedEvent dispatch, the ResetServicesListener subscribes to it and resets the resettable services. It allows --no-reset to work again because this option decides the ResetServicesListener to be added or not. Commits ------- 16cf4fc [Messenger] move resetting services at worker stopped into ResetServicesListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected
6.0.8
Description
Since this following commit, the option --no-reset does not work anymore. There is a ResetServicesListener that is in charge of this, so maybe we could move the function Worker::resetReceiverConnections() inside this listener when WorkerStoppedEvent is fired.
a4c8f4e
How to reproduce
Try to use bin/console messenger:consume with "--no-reset" option with the InMemoryTransport.
Possible Solution
There is a ResetServicesListener that is in charge of this, so maybe move the function Worker::resetReceiverConnections() inside this listener when WorkerStoppedEvent is fired.
Additional Context
No response
The text was updated successfully, but these errors were encountered: