Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Doctrine DBAL 4 compatibility #47962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmaicher opened this issue Oct 23, 2022 · 4 comments
Closed

Doctrine DBAL 4 compatibility #47962

dmaicher opened this issue Oct 23, 2022 · 4 comments
Labels
DoctrineBridge Help wanted Issues and PRs which are looking for volunteers to complete them. Keep open Status: Reviewed

Comments

@dmaicher
Copy link
Contributor

dmaicher commented Oct 23, 2022 •
edited
Loading

Description

Since the first BETA for DBAL 4 was just released I'm looking into making https://github.com/dmaicher/doctrine-test-bundle compatible with it.

On Symfony's side I noticed this error:

In Connection.php line 82:
                                                                                                                                                                                                             
  [Symfony\Component\ErrorHandler\Error\FatalError]                                                                                                                                                          
  Compile Error: Declaration of Symfony\Bridge\Doctrine\Middleware\Debug\Connection::beginTransaction(): bool must be compatible with Doctrine\DBAL\Driver\Middleware\AbstractConnectionMiddleware::beginTr  
  ansaction(): void                                                                                                                                                                                          
                                                                                                                                                                                                             

Exception trace:
  at /var/www/doctrine-test-bundle/vendor/symfony/doctrine-bridge/Middleware/Debug/Connection.php:82

The return type was changed to : void on DBAL 4. This also affects rollback() and commit().

I guess for now this is not high priority as the public API might still change for DBAL 4. But I just wanted to register this issue already for awareness.
@dmaicher dmaicher changed the title DBAL 4 compatibility Doctrine DBAL 4 compatibility Oct 23, 2022
@derrabus
Copy link
Member

Note: the ORM does not support DBAL 4 yet. That makes testing with DBAL 4 a bit difficult.

@kingjia90 kingjia90 mentioned this issue Nov 21, 2022
Closed
@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@derrabus derrabus added Status: Reviewed DoctrineBridge Help wanted Issues and PRs which are looking for volunteers to complete them. Keep open and removed Stalled labels May 3, 2023
@blankse
Copy link

blankse commented Oct 16, 2023

Fixed by #52035 ?

@stof stof closed this as completed Oct 16, 2023
@stof
Copy link
Member

stof commented Oct 16, 2023

@blankse indeed.

@ilvalerione ilvalerione mentioned this issue Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DoctrineBridge Help wanted Issues and PRs which are looking for volunteers to complete them. Keep open Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stof @dmaicher @blankse @derrabus @carsonbot