Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle][HttpKernel] Logger debug mode disabled #48040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatTheCat opened this issue Oct 29, 2022 · 0 comments · Fixed by #48041
Closed

[FrameworkBundle][HttpKernel] Logger debug mode disabled #48040

MatTheCat opened this issue Oct 29, 2022 · 0 comments · Fixed by #48041

Comments

@MatTheCat
Copy link
Contributor

MatTheCat commented Oct 29, 2022

Symfony version(s) affected

6.2-beta

Description

In #47483 I made Symfony\Component\HttpKernel\Log\Logger implement Symfony\Component\HttpKernel\Log\DebugLoggerInterface. But after testing against v6.2.0-BETA2 it appears logs are not collected. (It worked on my testing app because I had set the logger service myself.)

How to reproduce

Do not install Monolog and send some logs while the profiler is enabled. These logs won’t appear in the profiler.

Possible Solution

The issue stems from AddDebugLogProcessorPass (priority 2) being processed before the LoggerPass (priority -32).

Given #31509 I guess there are two ways to solve this:

  • create a distinct compiler pass for enabling HttpKernel’s logger debug mode
  • increase LoggerPass priority to at least 3

Not sure which one would be the best. #24300 (comment) does not help 😁

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants