-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Also listen to SIGINT
in StopWorkerOnSigtermSignalListener
#49156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
SIGINT
in StopWorkerOnSigtermSignalListener
What if make possible sygnals configurable via constructor? It could accept an array of posix signals which would stop the worker. For example in my project, we terminate workers with @lyrixx wdyt? |
How Would you configure the subscriber ? |
@lyrixx like this. Except
|
Sorry, I was not clear. With Symfony full stack, this service is not created by you, but by the framework. So how would you configure it? I think we can set some sane defaults, then if you want other signals, you replace the services arguments. Are you OK with this? I'll do the PR ASAP |
I opened a PR ☝ |
Description
ATM, StopWorkerOnSigtermSignalListener listen only
SIGTERM
.IMHO, it should also listen SIGINT (CTR+C) for the following reasons:
bin/console
🧓🏼), it's boring to stop them cleanly. CTRL+C is easiercc @Tobion
I'll make the PR if accepted
The text was updated successfully, but these errors were encountered: