Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Symfony/mailer makes invalid assumptions about SSL/TLS vs STARTTLS - unable to submit pull request #50150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShamimIslam opened this issue Apr 25, 2023 · 2 comments

Comments

@ShamimIslam
Copy link

Symfony version(s) affected

master

Description

Hi.

The current symfony/mailer assumes that encryption is the result of whether SSL/TLS has been selected or if the mailer supports STARTTLS. However, there is a scenario where NO ENCRYPTION is the requirement. I found the code and the files needing to be updated. But I am unable to find the same code to make the update in the main repo. When I create a PR in the other report (symfony/mailer), I get told that it is read only and I should make the PR in symfony/mailer.

Please let me know how to accomplish this.

Thanks.

How to reproduce

  1. Standard symfony.
  2. Set up your mailer to advertise STARTTLS but set the parameters wrong since you do not want to use encryption (externally maintained by third party so you cannot get to it)
  3. Request no encryption in the mailer on a custom port
  4. The mailer uses STARTTLS if the mail server reports it is available even though what you want is no encryption
  5. The mail attempt fails to login

Possible Solution

Update the symfony mailer to make the SSL/TLS, STARTTLS, NONE explicit and not rely on capabilities to automatically turn on something that is not requested.

Additional Context

Happy to create the PR, but I can't find where to make the PR. I submitted 2 but they got closed because the "repo is read-only."

@ghost
Copy link

ghost commented Apr 25, 2023

Happy to create the PR, but I can't find where to make the PR. I submitted 2 but they got closed because the "repo is read-only."

Symfony is a monorepo. All PRs should be created in symfony/symfony repository. Fork this repo and create PR here.

@derrabus
Copy link
Member

Duplicate of #49114

@derrabus derrabus marked this as a duplicate of #49114 Apr 25, 2023
@derrabus derrabus closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants