[Validator] Return types change on ExecutionContextInterface break BC #50526
Comments
|
Can you please send a PR to turn them into |
|
We only added PHP return types to the
|
…s in favor of docblock annotations.
|
Hi @upchuk. After a quick internal discussion, we've concluded that it was wrong to mark these methods as internal (as the interface is not internal). I've submitted a PR to remove the internal annotation: #50539 I see you started creating a PR for the return type already, can you finish that so we can give you credits for finding and reporting this issue? :) |
…s in favor of docblock annotations.
…s in favor of docblock annotations.
…void return types in favor of docblock annotations. (upchuk) This PR was merged into the 6.3 branch. Discussion ---------- [Validator] GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations. | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #50526 | License | MIT | Doc PR | Commits ------- 7c7b0b2 GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations.
* 6.3: [PhpUnitBridge] Ignore deprecations about the annotation mapping driver when it's not possible to move to the attribute driver yet [SecurityBundle] Mark SignatureAlgorithmFactory as internal remove unusable cache pools GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations.
* 6.4: [PhpUnitBridge] Ignore deprecations about the annotation mapping driver when it's not possible to move to the attribute driver yet [SecurityBundle] Mark SignatureAlgorithmFactory as internal remove unusable cache pools GH-50526: Reverting ExecutionContextInterface void return types in favor of docblock annotations.
|
@nicolas-grekas @stof Thanks for this. Do you plan on making a patch release to 6.3.0 to include this change? As it stands, we some problems in Drupal which implements this interface. Thanks! |
|
Yes, there will for sure be a 6.3.1 :) Normally, we release patch releases once a month. After a new minor release, we sometimes release 6.3.1 a bit quicker, but we also want to gather as much bug fixes for the .1 release as possible. Given there are no big bugs in 6.3.0, I think you can expect a 6.3.1 release in 1 to 3 weeks. |
|
@wouterj ok, cool, thanks! |
Symfony version(s) affected
6.3.0
Description
Hello,
I noticed that in 6.3.0 version of the Validator, the ExecutionContextInterface got it's public method signatures updated to add a return type: symfony/validator@c2801bc.
This breaks any implementation of the ExecutionContextInterface. AFAIK, minors should not make changes to public APIs no?
Thanks!
How to reproduce
No real steps.
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: