Hey @mhitza!

Yea, I expected this to happen eventually - I was curious to see what situation caused it exactly.

However, I wasn't able to repeat this: I created a new Symfony app, installed asset mapper, ran importmap:require htmlx.org and then added import 'htmx.org'; to my assets/app.js file. I also verified that HTMX was functioning correctly on my page.

Also, while I DO agree that @returns {import("./htmx").HtmxSwapSpecification} will incorrectly be matched by the regex, I can't see how it would trigger the circular reference. When we parse this, we would find ./htmx. But that class doesn't assume/add the .js onto the end. So it would try to look for a file called htmx, not htmx.js. And, while that might trigger a log warning when the assets build, it wouldn't create a real problem.

So I think there may be a legit issue here yet, but I'm still missing a piece. Do you have a reproducer?

Cheers!

The following code should create an appropiate environment (assuming all the tools are present, of course)

symfony new poc --version="6.3.*" --webapp

cd poc

composer require symfony/asset-mapper symfony/asset symfony/twig-pack

mkdir assets/js

curl https://raw.githubusercontent.com/bigskysoftware/htmx/master/src/htmx.js --output assets/js/htmx.js

echo "<script type=module>import '{{ asset('js/htmx.js') }}';</script></body>" > replace.txt

sed -i '/\/body>/r replace.txt' templates/base.html.twig

./bin/console make:controller HomeController

symfony serve

https://localhost:8000/home should show the error I've encountered.

I go through the process of manually updating my local htmx.js file by copying the source code from GitHub locally in assets/js/htmx.js . For this project, I don't use: 1) nodejs package manager, 2) js cdns, 3) minified or stripped code (well, not until a few days ago :) )

Fixed in: #51345 - the circular reference was actually triggered when trying to create an informative log message. After that PR, the parser will still incorrectly find these import statements, but they'll just be ignored as no htmx file exists (htmx.js exists, but not htmx). You may see a few warning logs about this - but those are just that: warnings - and they can be ignored.

Thanks for the quick-to-setup reproducer ❤️