Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecated everything related to *AnnotatedClassesToCompile* #52141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Oct 18, 2023 · 3 comments · Fixed by #53801
Closed

Deprecated everything related to *AnnotatedClassesToCompile* #52141

nicolas-grekas opened this issue Oct 18, 2023 · 3 comments · Fixed by #53801
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them.

Comments

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 18, 2023 •
edited
Loading

We use to have this code infrastructure to warmup doctrine/annotations. This is useless now.
@nicolas-grekas
Copy link
Member Author

the cache.annotations service should also be deprecated

@stof
Copy link
Member

stof commented Oct 18, 2023

I suggest deprecating that in 7.1 as bundles supporting 6.4 might still support annotations and so use it.

The infrastructure can become no-op in 7.0 (as we won't have annotations anymore)

@nicolas-grekas nicolas-grekas added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Oct 19, 2023
@alexandre-daubois
Copy link
Member

Isn't it a BC break to make the infrastructure become a no-op? Or is it actually just removing the $container->addCompilerPass(new AddAnnotatedClassesToCachePass($this)); call from Kernel in 7.0?

@nicolas-grekas nicolas-grekas mentioned this issue Feb 6, 2024
Merged
@fabpot fabpot closed this as completed Apr 8, 2024
fabpot added a commit that referenced this issue Apr 8, 2024
@fabpot
feature #53801 [HttpKernel] Deprecate `AddAnnotatedClassesToCachePass…
91dc097 
…` and related code infrastructure (nicolas-grekas)

This PR was merged into the 7.1 branch.

Discussion
----------

[HttpKernel] Deprecate `AddAnnotatedClassesToCachePass` and related code infrastructure

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Issues        | Fix #52141
| License       | MIT

These code paths are already no-ops in 7.1 since we don't support annotations anymore.

Commits
-------

ef95928 [HttpKernel] Deprecate `AddAnnotatedClassesToCachePass` and related code infrastructure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Milestone
No milestone
4 participants
@fabpot @nicolas-grekas @stof @alexandre-daubois