Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache][Messenger] Redis Sentinel configuration names are not streamlined even though they're doing exactly the same thing #52671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dkarlovi opened this issue Nov 21, 2023 · 1 comment · Fixed by #52893

Comments

@dkarlovi
Copy link
Contributor

Symfony version(s) affected

6.3.5

Description

For Messenger, Redis Transport takes sentinel_master.

For Cache, Redis Adapter takes redis_sentinel for the same use.

This creates friction where developers should reasonably expect the same configuration to have the same names. This is made worse by Cache DSN parser not reporting invalid config, which Messenger does.

How to reproduce

Check the docs.

Possible Solution

Streamline the namings.

Additional Context

No response

@nicolas-grekas
Copy link
Member

Let's support both keys everywhere. Up for a PR?

@fabpot fabpot closed this as completed Dec 8, 2023
fabpot added a commit that referenced this issue Dec 8, 2023
…nd sentinel_master available everywhere (xabbuh)

This PR was merged into the 7.1 branch.

Discussion
----------

[Cache][Messenger]  make both options redis_sentinel and sentinel_master available everywhere

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | Fix #52671
| License       | MIT

Commits
-------

7c1bfcf make both options redis_sentinel and sentinel_master available everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants