-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Workflow] Verify race condition #53179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What is the behaviour when executing this test? And what did you expect instead? |
back1:
Result: tokens in back2:
Result: token in The implementation is similar to Petri Nets, but with the difference that if another token moved to place, it will be ignored. That is the problem.
Like Petri Nets: back1:
Result: tokens in back2:
Result: tokens in |
Possible safe solution (need validate): Change
Add new argument to
In
This allows:
|
Hm... This has indeed been the case since forever. Interesting. Since we are building a list of "approved transitions" and then apply them one by one (and not as a unit) we will have this issue. With your proposed solution, do you see how/if that would effect listeners to |
Like Petri Nets (#53179 (comment)), but only in listeners must not be affected |
Behaviour should change when we set For example we can use
|
Alternatively - we can simply add a check for places in transitions with the same names in the |
It would not be a bug fix but a feature, since this was always intended this way, cf #22521 (comment). I would be happy to have such feature though, it has been on my todo list for a long time :). |
…tokens (lyrixx) This PR was merged into the 5.4 branch. Discussion ---------- [Workflow]Fix Marking when it must contains more than one tokens | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53179 | License | MIT Commits ------- 02b54a1 [Workflow] Fix Marking when it must contains more than one tokens
The PR has been reverted. I'll send another one against 7.1 |
Symfony version(s) affected
all
Description
The behavior of transitions depends on the order in which they are declared.
How to reproduce
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: