-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Closed
Description
Symfony version(s) affected
6.4.4
Description
After installing symfony/lock and configuring it with DoctrineDbalStore, I noticed that invoking doctrine:migrations:diff command would generate a migration issuing a DROP of the autogenerated lock_keys table.
After investigating, I found out the issue is line 33 of the listener. The $stores property receives a RewindableGenerator, which is then passed directly to an ArrayIterator. This produces an invalid iterator, skipping the whole following while loop.
How to reproduce
- Configure
symfony/lockwith aDoctrineDbalStore. - Generate the
lock_keystable, either by using theLockFactoryor by any other means mentioned in the docs. - Run the
doctrine:migrations:diffcommand. - See that the the schema for the table is not properly configured, resulting in a migration instead of the expected
No changes detected in your mapping information.message.
Possible Solution
Since the $stores property is already typed as iterable, it would seem replacing the loop with a foreach iterating directly on the property would be the best solution.
Additional Context
No response