You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Howevery, the class PropertyReadInfo is marked as @internal in it's docblock, causing the IDE and PHPStan to complain about usage of internal members.
I assume that creating a custom extractor is something that should be supported, as the documentation states [...] While you can create your own extractors, the following are already available to cover most use-cases
The same problem is with PropertyWriteInfo while implementing a custom class for PropertyWriteExtractorInterface.
Is it a wanted limitation or something we can fix?
Example
The new PropertyReadInfo and PropertyWriteInfo should not be marked as @internal
Before:
/** * The property read info tells how a property can be read. * * @author Joel Wurtz <[email protected]> * * @internal */finalclass PropertyReadInfo
{
}
After
/** * The property read info tells how a property can be read. * * @author Joel Wurtz <[email protected]> * */finalclass PropertyReadInfo
{
The text was updated successfully, but these errors were encountered:
Hey @Guarrakesh, indeed, I think something's going wrong here.
PropertyReadInfoExtractorInterface is not internal, but PropertyReadInfo is. Which makes implementing PropertyReadInfoExtractorInterface impossible to implement without going against the internal usage rule.
I think that your fix is the good approach. Up to create a PR? 🙂
Symfony IsVersions(s) Affected
All
Description
I'm trying to use a custom Read/Write Info Extractor within the PropertyAccessor.
Howevery, the class
PropertyReadInfo
is marked as@internal
in it's docblock, causing the IDE and PHPStan to complain about usage of internal members.I assume that creating a custom extractor is something that should be supported, as the documentation states [...] While you can create your own extractors, the following are already available to cover most use-cases
The same problem is with
PropertyWriteInfo
while implementing a custom class forPropertyWriteExtractorInterface
.Is it a wanted limitation or something we can fix?
Example
The new
PropertyReadInfo
andPropertyWriteInfo
should not be marked as@internal
Before:
After
The text was updated successfully, but these errors were encountered: