InlineFragmentRenderer always creates Request instance, instead of possible user-defined request class #7185
Comments
fabpot
added a commit
that referenced
this issue
Mar 15, 2013
This PR was merged into the 2.1 branch. Commits ------- e51432a sub-requests are now created with the same class as their parent Discussion ---------- [2.1] sub-requests are now created with the same class as their parent | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7185 --------------------------------------------------------------------------- by lsmith77 at 2013-03-14T19:54:13Z oh .. i thought this was already the case! --------------------------------------------------------------------------- by gnutix at 2013-03-15T09:57:55Z Thanks for the PR @jfsimon ! I just override the Request class for a custom getClientIp() method and I sure will need your fix in order for it to work in all scenarios. I'll test your patch in my project as soon as possible.
This was referenced Mar 15, 2013
fabpot
added a commit
that referenced
this issue
Mar 18, 2013
This PR was merged into the 2.2 branch. Commits ------- 53cf12b replaced new occurences of 'Request::create()' with '::create()' Discussion ---------- [2.2] sub-requests are now created with the same class as their parent Following #7381 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7185, #7186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to comment below this line, developer can use own Request class (subclass of standard Request class), but InlineFragmentRenderer always creates sub-request by calling
Request::create()method.The text was updated successfully, but these errors were encountered: