-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Tests segfault on PHP 5.3.3 #7754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Nevermind, build is back to normal now... |
This is unfortunately something that happens quite often. |
I started thinking it's because of some of the Process component tests, but i cannot prove it. I've investigate few segfaulting builds in the past, and those tests brought my attention several times. I hope parallelising the build (#7708) will solve this kind of issues (or at least make them easier to identify). |
Tests are segfaulting again, it seems that this time in a different place (much earlier). PHPUnit installed with composer doesn't have this problem. |
re #7947 |
This PR was merged into the master branch. Discussion ---------- Fixed the tests on PHP 5.3.3 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7754 | License | MIT | Doc PR | - PHPUnit with PHP 5.3.3 couldn't handle garbage collecting properly. Commits ------- 0617ed1 [Console] Removed the descriptor from data set providers.
Tests started failing after the 580b249 commit. However, it doesn't seem to be the actual cause, since php segfaults in a completely different place.
Disabling GC with gc_disable() makes that tests are not segfaulting anymore. However, some of them are failing (see my build with GC disabled).
The text was updated successfully, but these errors were encountered: