From 6aa4cd8319130e523a67dc3c27163b14d6181781 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Borrego=20Bernab=C3=A9?= Date: Sat, 29 Nov 2014 14:39:12 +0100 Subject: [PATCH 1/2] Adding a deprecation note about DialogHelper --- src/Symfony/Component/Console/Helper/DialogHelper.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/Console/Helper/DialogHelper.php b/src/Symfony/Component/Console/Helper/DialogHelper.php index 589568ec78892..af65790a519ed 100644 --- a/src/Symfony/Component/Console/Helper/DialogHelper.php +++ b/src/Symfony/Component/Console/Helper/DialogHelper.php @@ -20,7 +20,7 @@ * @author Fabien Potencier * * @deprecated Deprecated since version 2.5, to be removed in 3.0. - * Use the question helper instead. + * Use {@link \Symfony\Component\Console\Helper\QuestionHelper} instead. */ class DialogHelper extends InputAwareHelper { @@ -28,6 +28,12 @@ class DialogHelper extends InputAwareHelper private static $shell; private static $stty; + function __construct() + { + trigger_error( 'DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED ); + + parent::__construct(); + } /** * Asks the user to select a value. * From cbddc8dd966b0f1fcca8c3df62cd94d20ca63a7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Borrego=20Bernab=C3=A9?= Date: Sat, 29 Nov 2014 15:07:08 +0100 Subject: [PATCH 2/2] Coding style fixing --- src/Symfony/Component/Console/Helper/DialogHelper.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Console/Helper/DialogHelper.php b/src/Symfony/Component/Console/Helper/DialogHelper.php index af65790a519ed..8d76060d2299d 100644 --- a/src/Symfony/Component/Console/Helper/DialogHelper.php +++ b/src/Symfony/Component/Console/Helper/DialogHelper.php @@ -28,9 +28,9 @@ class DialogHelper extends InputAwareHelper private static $shell; private static $stty; - function __construct() + public function __construct() { - trigger_error( 'DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED ); + trigger_error('DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED); parent::__construct(); }