From 66385359779b6eec40970a161c85535d0665f1ec Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Fri, 12 Dec 2014 21:25:53 +0100 Subject: [PATCH 1/2] fix ocramius/proxy-manager dependency version Symfony 2.5 and higher requires ocramius/proxy-manager 0.4.0 or higher. --- composer.json | 2 +- src/Symfony/Bridge/ProxyManager/composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index dbceff5d31ac0..1d893fef234d7 100644 --- a/composer.json +++ b/composer.json @@ -72,7 +72,7 @@ "monolog/monolog": "~1.3", "propel/propel1": "~1.6", "ircmaxell/password-compat": "~1.0", - "ocramius/proxy-manager": "~0.3.1", + "ocramius/proxy-manager": "~0.4|~1.0", "egulias/email-validator": "~1.2" }, "autoload": { diff --git a/src/Symfony/Bridge/ProxyManager/composer.json b/src/Symfony/Bridge/ProxyManager/composer.json index d79d39cd93ba9..e4370f8f26b0b 100644 --- a/src/Symfony/Bridge/ProxyManager/composer.json +++ b/src/Symfony/Bridge/ProxyManager/composer.json @@ -18,7 +18,7 @@ "require": { "php": ">=5.3.3", "symfony/dependency-injection": "~2.3", - "ocramius/proxy-manager": "~0.3.1" + "ocramius/proxy-manager": "~0.4|~1.0" }, "require-dev": { "symfony/config": "~2.3" From 9b96373d10334c7b4a74c54e6a42f91e9c5c5e1f Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Sat, 13 Dec 2014 10:04:18 +0100 Subject: [PATCH 2/2] Fix failing tests after merge --- .../Constraints/CallbackValidator.php | 26 +++++++------------ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/Symfony/Component/Validator/Constraints/CallbackValidator.php b/src/Symfony/Component/Validator/Constraints/CallbackValidator.php index 6f073c7d87178..831bf80bd1822 100644 --- a/src/Symfony/Component/Validator/Constraints/CallbackValidator.php +++ b/src/Symfony/Component/Validator/Constraints/CallbackValidator.php @@ -58,24 +58,18 @@ public function validate($object, Constraint $constraint) } call_user_func($method, $object, $this->context); + } elseif (null !== $object) { + if (!method_exists($object, $method)) { + throw new ConstraintDefinitionException(sprintf('Method "%s" targeted by Callback constraint does not exist', $method)); + } - continue; - } - - if (null === $object) { - continue; - } - - if (!method_exists($object, $method)) { - throw new ConstraintDefinitionException(sprintf('Method "%s" targeted by Callback constraint does not exist', $method)); - } - - $reflMethod = new \ReflectionMethod($object, $method); + $reflMethod = new \ReflectionMethod($object, $method); - if ($reflMethod->isStatic()) { - $reflMethod->invoke(null, $object, $this->context); - } else { - $reflMethod->invoke($object, $this->context); + if ($reflMethod->isStatic()) { + $reflMethod->invoke(null, $object, $this->context); + } else { + $reflMethod->invoke($object, $this->context); + } } } }