From 55937c3645dc7191e05b4fc90290cc2bbcbe99b8 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Tue, 10 Feb 2015 15:42:09 +0100 Subject: [PATCH] turned deprecation notices as fatal when running unit tests --- autoload.php.dist | 20 +++++++++++-------- phpunit.xml.dist | 5 +---- src/Symfony/Bridge/Doctrine/phpunit.xml.dist | 4 +--- src/Symfony/Bridge/Monolog/phpunit.xml.dist | 4 +--- src/Symfony/Bridge/Propel1/phpunit.xml.dist | 4 +--- .../Bridge/ProxyManager/phpunit.xml.dist | 4 +--- src/Symfony/Bridge/Twig/phpunit.xml.dist | 4 +--- .../Bundle/DebugBundle/phpunit.xml.dist | 4 +--- .../Bundle/FrameworkBundle/phpunit.xml.dist | 4 +--- .../Bundle/SecurityBundle/phpunit.xml.dist | 4 +--- .../Bundle/TwigBundle/phpunit.xml.dist | 4 +--- .../Bundle/WebProfilerBundle/phpunit.xml.dist | 4 +--- .../Component/BrowserKit/phpunit.xml.dist | 4 +--- .../Component/ClassLoader/phpunit.xml.dist | 4 +--- src/Symfony/Component/Config/phpunit.xml.dist | 4 +--- .../Component/Console/phpunit.xml.dist | 4 +--- .../Component/CssSelector/phpunit.xml.dist | 4 +--- src/Symfony/Component/Debug/phpunit.xml.dist | 4 +--- .../DependencyInjection/phpunit.xml.dist | 4 +--- .../Component/DomCrawler/phpunit.xml.dist | 4 +--- .../EventDispatcher/phpunit.xml.dist | 4 +--- .../ExpressionLanguage/phpunit.xml.dist | 4 +--- .../Component/Filesystem/phpunit.xml.dist | 4 +--- src/Symfony/Component/Finder/phpunit.xml.dist | 4 +--- src/Symfony/Component/Form/phpunit.xml.dist | 4 +--- .../Component/HttpFoundation/phpunit.xml.dist | 4 +--- .../Component/HttpKernel/phpunit.xml.dist | 4 +--- src/Symfony/Component/Intl/phpunit.xml.dist | 4 +--- src/Symfony/Component/Locale/phpunit.xml.dist | 4 +--- .../OptionsResolver/phpunit.xml.dist | 4 +--- .../Component/Process/phpunit.xml.dist | 4 +--- .../Component/PropertyAccess/phpunit.xml.dist | 4 +--- .../Component/Routing/phpunit.xml.dist | 4 +--- .../Component/Security/Acl/phpunit.xml.dist | 4 +--- .../Component/Security/Core/phpunit.xml.dist | 4 +--- .../Component/Security/Csrf/phpunit.xml.dist | 4 +--- .../Component/Security/Http/phpunit.xml.dist | 4 +--- .../Component/Security/phpunit.xml.dist | 4 +--- .../Component/Serializer/phpunit.xml.dist | 4 +--- .../Component/Stopwatch/phpunit.xml.dist | 4 +--- .../Component/Templating/phpunit.xml.dist | 4 +--- .../Component/Translation/phpunit.xml.dist | 4 +--- .../Component/Validator/phpunit.xml.dist | 4 +--- .../Component/VarDumper/phpunit.xml.dist | 4 +--- src/Symfony/Component/Yaml/phpunit.xml.dist | 4 +--- 45 files changed, 56 insertions(+), 141 deletions(-) diff --git a/autoload.php.dist b/autoload.php.dist index 3b3297d924301..25661709e5b52 100644 --- a/autoload.php.dist +++ b/autoload.php.dist @@ -44,19 +44,23 @@ class DeprecationErrorHandler $class = isset($trace[$i]['object']) ? get_class($trace[$i]['object']) : $trace[$i]['class']; $method = $trace[$i]['function']; - $type = 0 === strpos($method, 'testLegacy') || 0 === strpos($method, 'provideLegacy') || 0 === strpos($method, 'getLegacy') || strpos($class, '\Legacy') ? 'legacy' : 'remaining'; + $deprecationType = 0 === strpos($method, 'testLegacy') || 0 === strpos($method, 'provideLegacy') || 0 === strpos($method, 'getLegacy') || strpos($class, '\Legacy') ? 'legacy' : 'remaining'; - if ('legacy' === $type && 0 === (error_reporting() & E_USER_DEPRECATED)) { - @++$deprecations[$type]['Silenced']['count']; + if ('legacy' === $deprecationType && 0 === (error_reporting() & E_USER_DEPRECATED)) { + @++$deprecations[$deprecationType]['Silenced']['count']; } else { - @++$deprecations[$type][$msg]['count']; - @++$deprecations[$type][$msg][$class.'::'.$method]; + @++$deprecations[$deprecationType][$msg]['count']; + @++$deprecations[$deprecationType][$msg][$class.'::'.$method]; } } else { - $type = 'other'; - @++$deprecations[$type][$msg]['count']; + $deprecationType = 'other'; + @++$deprecations[$deprecationType][$msg]['count']; + } + ++$deprecations[$deprecationType.'Count']; + + if ('legacy' !== $deprecationType) { + return PHPUnit_Util_ErrorHandler::handleError($type, $msg, $file, $line, $context); } - ++$deprecations[$type.'Count']; }; $oldErrorHandler = set_error_handler($deprecationHandler); diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 25bff1fbcc125..0eca4fb69426b 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -7,10 +7,7 @@ bootstrap="autoload.php.dist" > - - - - + diff --git a/src/Symfony/Bridge/Doctrine/phpunit.xml.dist b/src/Symfony/Bridge/Doctrine/phpunit.xml.dist index 81fb10104a9a3..1078af867d3a5 100644 --- a/src/Symfony/Bridge/Doctrine/phpunit.xml.dist +++ b/src/Symfony/Bridge/Doctrine/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="Tests/bootstrap.php" > - - - + diff --git a/src/Symfony/Bridge/Monolog/phpunit.xml.dist b/src/Symfony/Bridge/Monolog/phpunit.xml.dist index 35113fe3760c0..34063ac548676 100644 --- a/src/Symfony/Bridge/Monolog/phpunit.xml.dist +++ b/src/Symfony/Bridge/Monolog/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bridge/Propel1/phpunit.xml.dist b/src/Symfony/Bridge/Propel1/phpunit.xml.dist index cb2417a59e59a..2b90f13b97524 100644 --- a/src/Symfony/Bridge/Propel1/phpunit.xml.dist +++ b/src/Symfony/Bridge/Propel1/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bridge/ProxyManager/phpunit.xml.dist b/src/Symfony/Bridge/ProxyManager/phpunit.xml.dist index 8d0294c6eb242..60980be9e531e 100644 --- a/src/Symfony/Bridge/ProxyManager/phpunit.xml.dist +++ b/src/Symfony/Bridge/ProxyManager/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bridge/Twig/phpunit.xml.dist b/src/Symfony/Bridge/Twig/phpunit.xml.dist index cf2e90264ba57..10c0be1142712 100644 --- a/src/Symfony/Bridge/Twig/phpunit.xml.dist +++ b/src/Symfony/Bridge/Twig/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bundle/DebugBundle/phpunit.xml.dist b/src/Symfony/Bundle/DebugBundle/phpunit.xml.dist index 8eb57b64eab31..cbde5628a3987 100644 --- a/src/Symfony/Bundle/DebugBundle/phpunit.xml.dist +++ b/src/Symfony/Bundle/DebugBundle/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bundle/FrameworkBundle/phpunit.xml.dist b/src/Symfony/Bundle/FrameworkBundle/phpunit.xml.dist index 22ffb9c1e5d4f..269adda917a1b 100644 --- a/src/Symfony/Bundle/FrameworkBundle/phpunit.xml.dist +++ b/src/Symfony/Bundle/FrameworkBundle/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bundle/SecurityBundle/phpunit.xml.dist b/src/Symfony/Bundle/SecurityBundle/phpunit.xml.dist index 231b22d8bf3f1..0ff2b570e2736 100644 --- a/src/Symfony/Bundle/SecurityBundle/phpunit.xml.dist +++ b/src/Symfony/Bundle/SecurityBundle/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bundle/TwigBundle/phpunit.xml.dist b/src/Symfony/Bundle/TwigBundle/phpunit.xml.dist index 94a8bbd399f67..763b8b68bf826 100644 --- a/src/Symfony/Bundle/TwigBundle/phpunit.xml.dist +++ b/src/Symfony/Bundle/TwigBundle/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Bundle/WebProfilerBundle/phpunit.xml.dist b/src/Symfony/Bundle/WebProfilerBundle/phpunit.xml.dist index 0056f47b84f5e..f449adf319706 100644 --- a/src/Symfony/Bundle/WebProfilerBundle/phpunit.xml.dist +++ b/src/Symfony/Bundle/WebProfilerBundle/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/BrowserKit/phpunit.xml.dist b/src/Symfony/Component/BrowserKit/phpunit.xml.dist index fe2aa44e99823..d76b2b98afd80 100644 --- a/src/Symfony/Component/BrowserKit/phpunit.xml.dist +++ b/src/Symfony/Component/BrowserKit/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/ClassLoader/phpunit.xml.dist b/src/Symfony/Component/ClassLoader/phpunit.xml.dist index 4228f7681e98b..4856db5be65d1 100644 --- a/src/Symfony/Component/ClassLoader/phpunit.xml.dist +++ b/src/Symfony/Component/ClassLoader/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Config/phpunit.xml.dist b/src/Symfony/Component/Config/phpunit.xml.dist index 326db410773f3..3fe6fd87c8499 100644 --- a/src/Symfony/Component/Config/phpunit.xml.dist +++ b/src/Symfony/Component/Config/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Console/phpunit.xml.dist b/src/Symfony/Component/Console/phpunit.xml.dist index 908e0aac7f6d8..ae0dcbeaba41c 100644 --- a/src/Symfony/Component/Console/phpunit.xml.dist +++ b/src/Symfony/Component/Console/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/CssSelector/phpunit.xml.dist b/src/Symfony/Component/CssSelector/phpunit.xml.dist index 974af3ff02e77..14a320c873c11 100644 --- a/src/Symfony/Component/CssSelector/phpunit.xml.dist +++ b/src/Symfony/Component/CssSelector/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Debug/phpunit.xml.dist b/src/Symfony/Component/Debug/phpunit.xml.dist index 82d69681dcd21..20b0313f0cd89 100644 --- a/src/Symfony/Component/Debug/phpunit.xml.dist +++ b/src/Symfony/Component/Debug/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/DependencyInjection/phpunit.xml.dist b/src/Symfony/Component/DependencyInjection/phpunit.xml.dist index b5b3ed2ea83d0..86252d0456ba9 100644 --- a/src/Symfony/Component/DependencyInjection/phpunit.xml.dist +++ b/src/Symfony/Component/DependencyInjection/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/DomCrawler/phpunit.xml.dist b/src/Symfony/Component/DomCrawler/phpunit.xml.dist index c099dac312120..d15dd6a48ed1e 100644 --- a/src/Symfony/Component/DomCrawler/phpunit.xml.dist +++ b/src/Symfony/Component/DomCrawler/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/EventDispatcher/phpunit.xml.dist b/src/Symfony/Component/EventDispatcher/phpunit.xml.dist index a710ca311c41e..ae0586e0b33de 100644 --- a/src/Symfony/Component/EventDispatcher/phpunit.xml.dist +++ b/src/Symfony/Component/EventDispatcher/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/ExpressionLanguage/phpunit.xml.dist b/src/Symfony/Component/ExpressionLanguage/phpunit.xml.dist index 641e0d4944621..183770651e26d 100644 --- a/src/Symfony/Component/ExpressionLanguage/phpunit.xml.dist +++ b/src/Symfony/Component/ExpressionLanguage/phpunit.xml.dist @@ -12,9 +12,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Filesystem/phpunit.xml.dist b/src/Symfony/Component/Filesystem/phpunit.xml.dist index cd8054f7351b6..7c6ba7aba3fb3 100644 --- a/src/Symfony/Component/Filesystem/phpunit.xml.dist +++ b/src/Symfony/Component/Filesystem/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Finder/phpunit.xml.dist b/src/Symfony/Component/Finder/phpunit.xml.dist index a6ede9df13afb..631e570b9479f 100644 --- a/src/Symfony/Component/Finder/phpunit.xml.dist +++ b/src/Symfony/Component/Finder/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Form/phpunit.xml.dist b/src/Symfony/Component/Form/phpunit.xml.dist index 09189b0eff7bc..fd668a9e8b779 100644 --- a/src/Symfony/Component/Form/phpunit.xml.dist +++ b/src/Symfony/Component/Form/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/HttpFoundation/phpunit.xml.dist b/src/Symfony/Component/HttpFoundation/phpunit.xml.dist index 3d675609db7b5..9ffdb43a2d744 100644 --- a/src/Symfony/Component/HttpFoundation/phpunit.xml.dist +++ b/src/Symfony/Component/HttpFoundation/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/HttpKernel/phpunit.xml.dist b/src/Symfony/Component/HttpKernel/phpunit.xml.dist index c6ddea4f6768a..13149663e488a 100644 --- a/src/Symfony/Component/HttpKernel/phpunit.xml.dist +++ b/src/Symfony/Component/HttpKernel/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Intl/phpunit.xml.dist b/src/Symfony/Component/Intl/phpunit.xml.dist index 007d574e85ce9..e42226a1b1240 100644 --- a/src/Symfony/Component/Intl/phpunit.xml.dist +++ b/src/Symfony/Component/Intl/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Locale/phpunit.xml.dist b/src/Symfony/Component/Locale/phpunit.xml.dist index 24dd5d8028b69..0d9b637cc78d1 100644 --- a/src/Symfony/Component/Locale/phpunit.xml.dist +++ b/src/Symfony/Component/Locale/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/OptionsResolver/phpunit.xml.dist b/src/Symfony/Component/OptionsResolver/phpunit.xml.dist index 43fb0345e3572..5a2316a1c9df5 100644 --- a/src/Symfony/Component/OptionsResolver/phpunit.xml.dist +++ b/src/Symfony/Component/OptionsResolver/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Process/phpunit.xml.dist b/src/Symfony/Component/Process/phpunit.xml.dist index a7f26b362181b..b5d605c2efbbe 100644 --- a/src/Symfony/Component/Process/phpunit.xml.dist +++ b/src/Symfony/Component/Process/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/PropertyAccess/phpunit.xml.dist b/src/Symfony/Component/PropertyAccess/phpunit.xml.dist index d4a0e024ccdae..fcf5f6ae56dd3 100644 --- a/src/Symfony/Component/PropertyAccess/phpunit.xml.dist +++ b/src/Symfony/Component/PropertyAccess/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Routing/phpunit.xml.dist b/src/Symfony/Component/Routing/phpunit.xml.dist index 4e2594d83873a..a9083088a9644 100644 --- a/src/Symfony/Component/Routing/phpunit.xml.dist +++ b/src/Symfony/Component/Routing/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Security/Acl/phpunit.xml.dist b/src/Symfony/Component/Security/Acl/phpunit.xml.dist index 20d1b803b9d82..755233957585a 100644 --- a/src/Symfony/Component/Security/Acl/phpunit.xml.dist +++ b/src/Symfony/Component/Security/Acl/phpunit.xml.dist @@ -12,9 +12,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Security/Core/phpunit.xml.dist b/src/Symfony/Component/Security/Core/phpunit.xml.dist index 7a5f7da9562c5..8a1a2914b095b 100644 --- a/src/Symfony/Component/Security/Core/phpunit.xml.dist +++ b/src/Symfony/Component/Security/Core/phpunit.xml.dist @@ -12,9 +12,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Security/Csrf/phpunit.xml.dist b/src/Symfony/Component/Security/Csrf/phpunit.xml.dist index f6e9005bdb116..8f950a3d3d441 100644 --- a/src/Symfony/Component/Security/Csrf/phpunit.xml.dist +++ b/src/Symfony/Component/Security/Csrf/phpunit.xml.dist @@ -12,9 +12,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Security/Http/phpunit.xml.dist b/src/Symfony/Component/Security/Http/phpunit.xml.dist index 58fe58e132f8e..49b36f271804e 100644 --- a/src/Symfony/Component/Security/Http/phpunit.xml.dist +++ b/src/Symfony/Component/Security/Http/phpunit.xml.dist @@ -12,9 +12,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Security/phpunit.xml.dist b/src/Symfony/Component/Security/phpunit.xml.dist index 7cbf08aed8295..7747b371c1713 100644 --- a/src/Symfony/Component/Security/phpunit.xml.dist +++ b/src/Symfony/Component/Security/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Serializer/phpunit.xml.dist b/src/Symfony/Component/Serializer/phpunit.xml.dist index 308efc737ec98..b2242e74fc0a9 100644 --- a/src/Symfony/Component/Serializer/phpunit.xml.dist +++ b/src/Symfony/Component/Serializer/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="Tests/bootstrap.php" > - - - + diff --git a/src/Symfony/Component/Stopwatch/phpunit.xml.dist b/src/Symfony/Component/Stopwatch/phpunit.xml.dist index 24e7e4101b8c6..b16dcaebf9a47 100644 --- a/src/Symfony/Component/Stopwatch/phpunit.xml.dist +++ b/src/Symfony/Component/Stopwatch/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Templating/phpunit.xml.dist b/src/Symfony/Component/Templating/phpunit.xml.dist index 34ca2f294395d..df25a4688c772 100644 --- a/src/Symfony/Component/Templating/phpunit.xml.dist +++ b/src/Symfony/Component/Templating/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Translation/phpunit.xml.dist b/src/Symfony/Component/Translation/phpunit.xml.dist index c0777909d2200..9788557d0cacf 100644 --- a/src/Symfony/Component/Translation/phpunit.xml.dist +++ b/src/Symfony/Component/Translation/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Validator/phpunit.xml.dist b/src/Symfony/Component/Validator/phpunit.xml.dist index e10097795d076..0e8c1e28145b0 100644 --- a/src/Symfony/Component/Validator/phpunit.xml.dist +++ b/src/Symfony/Component/Validator/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="Tests/bootstrap.php" > - - - + diff --git a/src/Symfony/Component/VarDumper/phpunit.xml.dist b/src/Symfony/Component/VarDumper/phpunit.xml.dist index ee3d4c2fe3c90..05128b9fa1a34 100644 --- a/src/Symfony/Component/VarDumper/phpunit.xml.dist +++ b/src/Symfony/Component/VarDumper/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - + diff --git a/src/Symfony/Component/Yaml/phpunit.xml.dist b/src/Symfony/Component/Yaml/phpunit.xml.dist index 2d11e6fc2cc01..418b2c6c9ad5a 100644 --- a/src/Symfony/Component/Yaml/phpunit.xml.dist +++ b/src/Symfony/Component/Yaml/phpunit.xml.dist @@ -7,9 +7,7 @@ bootstrap="vendor/autoload.php" > - - - +