[Yaml] removed YAML parser \ escaping in double-quotes #16203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +114,8 @@ public function unescapeCharacter($value) | |||
| return self::utf8chr(hexdec(substr($value, 2, 4))); | |||
| case 'U': | |||
| return self::utf8chr(hexdec(substr($value, 2, 8))); | |||
| default: | |||
| throw new ParseException(sprintf('Found unknown escape character (%s in \\%s).', $value, $value)); | |||
There was a problem hiding this comment.
in case '' === $value, the message could be enhanced imo
There was a problem hiding this comment.
As mentioned in https://github.com/symfony/symfony/pull/16201/files#r41711538, this is not possible.
12bdf79 to
558ddaa
Compare
|
rebased |
| @@ -63,7 +65,7 @@ public function unescapeDoubleQuotedString($value) | |||
| * @internal This method is public to be usable as callback. It should not | |||
There was a problem hiding this comment.
you should remove the internal tag too
|
👍 |
fabpot
added a commit
that referenced
this pull request
Oct 12, 2015
… (fabpot) This PR was merged into the 3.0-dev branch. Discussion ---------- [Yaml] removed YAML parser \ escaping in double-quotes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Should be rebased when #16201 is merged. Commits ------- 5dbf6bc [Yaml] removed parsing of non-escaped backslash in a double-quoted string
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be rebased when #16201 is merged.