From 6033503b5b2302b15cb79b1fd345eb45ba145db3 Mon Sep 17 00:00:00 2001 From: Dany Maillard Date: Tue, 4 Jul 2017 11:20:25 +0200 Subject: [PATCH] Remove enhancement Windows compatibility --- src/Symfony/Component/Process/Process.php | 37 +---------------------- 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php index d74c38afe8850..a34db920ef545 100644 --- a/src/Symfony/Component/Process/Process.php +++ b/src/Symfony/Component/Process/Process.php @@ -64,7 +64,6 @@ class Process implements \IteratorAggregate private $outputDisabled = false; private $stdout; private $stderr; - private $enhanceWindowsCompatibility = true; private $enhanceSigchildCompatibility; private $process; private $status = self::STATUS_READY; @@ -295,7 +294,7 @@ public function start(callable $callback = null, array $env = array()) $options = array('suppress_errors' => true); - if ('\\' === DIRECTORY_SEPARATOR && $this->enhanceWindowsCompatibility) { + if ('\\' === DIRECTORY_SEPARATOR) { $options['bypass_shell'] = true; $commandline = $this->prepareWindowsCommandLine($commandline, $envBackup, $env); } elseif (!$this->useFileHandles && $this->enhanceSigchildCompatibility && $this->isSigchildEnabled()) { @@ -1154,40 +1153,6 @@ public function setInput($input) return $this; } - /** - * Gets whether or not Windows compatibility is enabled. - * - * This is true by default. - * - * @return bool - * - * @deprecated since version 3.3, to be removed in 4.0. Enhanced Windows compatibility will always be enabled. - */ - public function getEnhanceWindowsCompatibility() - { - @trigger_error(sprintf('The %s() method is deprecated since version 3.3 and will be removed in 4.0. Enhanced Windows compatibility will always be enabled.', __METHOD__), E_USER_DEPRECATED); - - return $this->enhanceWindowsCompatibility; - } - - /** - * Sets whether or not Windows compatibility is enabled. - * - * @param bool $enhance - * - * @return self The current Process instance - * - * @deprecated since version 3.3, to be removed in 4.0. Enhanced Windows compatibility will always be enabled. - */ - public function setEnhanceWindowsCompatibility($enhance) - { - @trigger_error(sprintf('The %s() method is deprecated since version 3.3 and will be removed in 4.0. Enhanced Windows compatibility will always be enabled.', __METHOD__), E_USER_DEPRECATED); - - $this->enhanceWindowsCompatibility = (bool) $enhance; - - return $this; - } - /** * Returns whether sigchild compatibility mode is activated or not. *