[DependencyInjection] fix DOM element namespace URL access #29992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 26, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
commented
Jan 26, 2019
| @@ -672,7 +672,7 @@ private function validateAlias(\DOMElement $alias, $file) | |||
| } | |||
|
|
|||
| foreach ($alias->childNodes as $child) { | |||
| if (!$child instanceof \DOMElement && self::NS !== $child->namespaceURI) { | |||
| if (!$child instanceof \DOMElement || self::NS !== $child->namespaceURI) { | |||
There was a problem hiding this comment.
Originally there was no continue statement (this was introduced in #29968). The condition before read like this:
if ($child instanceof \DOMElement && self::NS === $child->namespaceURI) {
throw new InvalidArgumentException(sprintf('Invalid child element "%s" defined for alias "%s" in "%s".', $child->localName, $alias->getAttribute('id'), $file));
}This change ensures that we do not access a potentially not existing $namespaceURI property when $child is no DOMElement instance.
|
Good catch, thanks @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 26, 2019
… (xabbuh) This PR was merged into the 4.3-dev branch. Discussion ---------- [DependencyInjection] fix DOM element namespace URL access | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 429bddf fix DOM element namespace URL access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.