-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Yaml] fix comment in multi line value #32767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
61130c4
to
0fb6052
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be merged into 3.4 right?
0fb6052
to
2dd081a
Compare
Also 4.3 is affected, i think this should merged into 4.3 and 3.4. Multi-line strings support will be removed in 4.4 and 5.0 versions, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soufianZantar I have rebased your PR on the 3.4
branch. There's only one minor thing left to do. After that the PR is ready to be merged. Thanks for your work on this.
1213324
to
dd945e3
Compare
Thank you @soufianZantar. |
This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] fix comment in multi line value | Q | A | ------------- | --- | Branch? | 4.3 and lower <!-- see below --> | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32667 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Comments after blank lines are read as value in yaml. ``` `$yaml = <<<YAML parameters: abc # Comment YAML; var_dump(Symfony\Component\Yaml\Yaml::parse($yaml));` ``` **Result before fix:** ``` array(1) { ["parameters"]=> string(13) "abc # Comment" } ``` **Result after fix:** ``` array(1) { ["parameters"]=> string(3) "abc" } ``` Commits ------- dd945e3 fix(yml): fix comment in milti line value
Comments after blank lines are read as value in yaml.
Result before fix:
Result after fix: