PlantUmlDumper: use str_starts_with() #44476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of substr()
fancyweb
suggested changes
Dec 6, 2021
There was a problem hiding this comment.
Hello, thank you for updating your previous work. I think the PR should target 4.4 and symfony/polyfill-php80 should be required, check #41576 for inspiration.
Also I think you can replace more occurrences (if you have time :-)) where substr is used instead of str_starts_with and str_ends_with, there are probably some others.
|
Thanks for the review, I targeted the last branch because it didn't look like a bug fix. Let's do this in #44482 |
GromNaN
added a commit
that referenced
this pull request
Dec 7, 2021
This PR was squashed before being merged into the 6.1 branch. Discussion ---------- Use str_ends_with() and str_starts_with() | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no Use `str_ends_with()` and `str_starts_with()` instead of `substr()`. (replaces #44482 and #44476 🥲) Commits ------- 28d4d6b Use str_ends_with() and str_starts_with()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of substr()
Use
str_starts_with()instead ofsubstr()(in a code I wrote a while ago for #29538).