Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] allow Mailchimp to handle multiple TagHeader's #45274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2022
Merged

[Mailer] allow Mailchimp to handle multiple TagHeader's #45274

merged 1 commit into from
Feb 2, 2022

Conversation

kbond
Copy link
Member

@kbond kbond commented Feb 1, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

When adding multiple tags (for transports that support this), it's recommended to add multiple TagHeader's instead of a single header with a transport-specific way to separating.

$email->getHeaders()->add(new TagHeader('tag1'));
$email->getHeaders()->add(new TagHeader('tag2'));

// not
$email->getHeaders()->add(new TagHeader('tag1,tag2'));

This fixes mailchimp to allow this. I've left the comma separated method intact as to not cause a BC break.

@carsonbot carsonbot added this to the 5.4 milestone Feb 1, 2022
@fabpot
Copy link
Member

fabpot commented Feb 2, 2022

Thank you @kbond.

@fabpot fabpot merged commit d7da823 into symfony:5.4 Feb 2, 2022
This was referenced Feb 28, 2022
Merged
Merged
@starred-gijs starred-gijs mentioned this pull request Mar 1, 2022
Merged
@kbond kbond deleted the mailchimp-multiple-tags branch March 1, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kbond @fabpot @carsonbot