Thanks to visit codestin.com
Credit goes to github.com

Skip to content

revert #47270 to not use microtime() in the NativeClock #47319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

revert #47270 to not use microtime() in the NativeClock #47319

merged 1 commit into from
Aug 18, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 18, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh
Revert "minor symfony#47270 [Clock] fix transient NativeClock test (x…
21f4055 
…abbuh)"

This reverts commit fc868f4, reversing
changes made to 2e87d30.
@xabbuh xabbuh added this to the 6.2 milestone Aug 18, 2022
nicolas-grekas
nicolas-grekas reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 since using microtime(true) involves a big loss of precision on 32b archs, and because using createFromFormat makes generating the date slower than expected.
We need to find another strategy to make tests not transient....

@xabbuh xabbuh merged commit a89a23b into symfony:6.2 Aug 18, 2022
@xabbuh xabbuh deleted the pr-47270 branch August 18, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @stof @carsonbot