Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation][HttpKernel] Add missing void PHPdoc return types #49599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

[HttpFoundation][HttpKernel] Add missing void PHPdoc return types #49599

merged 1 commit into from
Mar 6, 2023

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Mar 4, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no (void return types don't get a deprecation notice)
Tickets Fix part of #47551 , ref #49439
License MIT
Doc PR -

@carsonbot carsonbot added this to the 6.3 milestone Mar 4, 2023
@wouterj wouterj force-pushed the http-return-types branch from 5ec8b0c to ca1b9e1 Compare March 4, 2023 15:33
@wouterj
Copy link
Member Author

wouterj commented Mar 4, 2023

Fabbot failures are false-positives

nicolas-grekas
nicolas-grekas approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a rule of thumb, .github/expected-missing-return-types.diff shouldn't contain any *Tests* classes, since these can be patched without breaking BC.

I updated the PR accordingly + added @return void on MicroKernelTrait::registerContainerConfiguration()

@nicolas-grekas
Copy link
Member

Thank you @wouterj.

@nicolas-grekas nicolas-grekas merged commit 32f2ec9 into symfony:6.3 Mar 6, 2023
@wouterj wouterj deleted the http-return-types branch March 6, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
HttpFoundation HttpKernel Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @nicolas-grekas @carsonbot