From 86194eabd4037943b822a0e8e5660e7d2d6eb0e8 Mon Sep 17 00:00:00 2001 From: aslangery <35818954+aslangery@users.noreply.github.com> Date: Fri, 8 Dec 2023 16:04:24 +0300 Subject: [PATCH 1/2] Update EsmtpTransportFactory.php fix: It's not possible to create a stream without tls --- .../Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php b/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php index a15d12245d19b..7c177524554d1 100644 --- a/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php +++ b/src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php @@ -23,7 +23,7 @@ final class EsmtpTransportFactory extends AbstractTransportFactory { public function create(Dsn $dsn): TransportInterface { - $tls = 'smtps' === $dsn->getScheme() ? true : null; + $tls = 'smtps' === $dsn->getScheme(); $port = $dsn->getPort(0); $host = $dsn->getHost(); From 73835d7f402ecd9880d0a6f22f8f4214544e4fd7 Mon Sep 17 00:00:00 2001 From: aslangery Date: Fri, 8 Dec 2023 23:56:40 +0300 Subject: [PATCH 2/2] added test case --- .../Tests/Transport/Smtp/EsmtpTransportFactoryTest.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportFactoryTest.php b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportFactoryTest.php index c2868ccbd8e99..c401ba4241941 100644 --- a/src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportFactoryTest.php +++ b/src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportFactoryTest.php @@ -157,5 +157,12 @@ public static function createProvider(): iterable new Dsn('smtps', 'example.com', '', '', 465, ['ping_threshold' => '10']), $transport, ]; + + $transport = new EsmtpTransport('example.com', 465, false, null, $logger); + + yield [ + new Dsn('smtp', 'example.com', '', '', 465), + $transport, + ]; } }